Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Request type #14300

Open
lforst opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14317
Open

Rename Request type #14300

lforst opened this issue Nov 14, 2024 · 0 comments · May be fixed by #14317
Assignees
@mydea

Comments

@lforst
Copy link
Member

lforst commented Nov 14, 2024 •
edited
Loading

Description

Our Request type should be renamed to not clash with the built-in type.

sentry-javascript/packages/types/src/request.ts

Lines 3 to 5 in f4c5900

* TODO(v9): Rename this to avoid confusion, because Request is also a native type.
*/
export interface Request {

Tasks:

  • Add alias for type (e.g. "SentryRequestData", "RequestContextData", TBD)
  • Deprecate old Request type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref(types): Deprecate Request type in favor of RequestEventData getsentry/sentry-javascript
2 participants
@mydea @lforst