Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JavaScript] Implement more auto instrumentation for Node.js #13317

Closed
mydea opened this issue Aug 12, 2024 · 3 comments
Closed

[JavaScript] Implement more auto instrumentation for Node.js #13317

mydea opened this issue Aug 12, 2024 · 3 comments
Assignees
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry

Comments

@mydea
Copy link
Member

mydea commented Aug 12, 2024

Description

We currently already ship some auto-performance instrumentation with @sentry/node. Now that things have stabilised a bit, we want to expand support and add further instrumentation. There are some low hanging fruits, in OTEL instrumentation that exists that we can leverage.

@mydea mydea added Package-Meta: OpenTelemetry Package: node Issues related to the Sentry Node SDK labels Aug 12, 2024
@stephanie-anderson stephanie-anderson changed the title Add additional Node Auto Instrumentation [JavaScript] Increase auto instrumentation for Node.js Sep 25, 2024
@mydea mydea changed the title [JavaScript] Increase auto instrumentation for Node.js [JavaScript] Implement more auto instrumentation for Node.js Sep 26, 2024
AbhiPrasad added a commit that referenced this issue Nov 11, 2024
Related to #13317

Improve the docstrings and link to documentation pages as appropriate
(as they contain information about opentelemetry and supported
versions).
@AbhiPrasad
Copy link
Member

Thanks to help from @Zen-cronic and our js sdk commiters, we've gotten to a pretty good state with this issue.

We've added default integrations for tedious, kafkajs, amqplib, lruMemoizer, and genericPool.

We've added opt-in integrations for dataloader (upstream OTEL fix needed) and knex (upstream OTEL fix needed).

We decided against including socket io instrumentation because of some concerns about long running spans in the sdk, and the fact that we don't have websockets well specced out in general in Sentry's tracing model.

The only things left are Express v5 and Firebase. Express v5 is being actively worked on, we're going to rely on diagnostics channels to do it, just need upstream work for it. Firebase PR is WIP, but I think it can be worked on past this issue.

There'a also the vercel AI work which is tracked here: #13679

Once we merge in Vercel AI and do the next release of the SDK, I'll be closing this issue. Express 5, firebase, the dataloader fix can be tracked outside of this issue.

@AbhiPrasad
Copy link
Member

Opened getsentry/sentry-docs#11799 to document the remaining integrations added in https://github.com/getsentry/sentry-javascript/releases/tag/8.38.0, as well as clean up some old entries.

@AbhiPrasad
Copy link
Member

Closing now that we merged in #13679

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: node Issues related to the Sentry Node SDK Package-Meta: OpenTelemetry
Projects
None yet
Development

No branches or pull requests

2 participants