Replies: 2 comments
-
I just found this in the V8 docs, confirming that it should probably be deprecated: sentry-javascript/docs/v8-new-performance-apis.md Lines 246 to 249 in 5c08d03 |
Beta Was this translation helpful? Give feedback.
0 replies
-
I was able to add request attributes to the root span using new HttpInstrumentation({
startIncomingSpanHook(req) {
const attrs: SpanAttributes = {};
const myHeader = req.headers["my_header"];
if (myHeader) {
attrs["my_header"] = myHeader;
}
return attrs;
},
}) |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
It seems like
SamplingContext.request
alwaysundefined
fortracesSampler
in Sentry 8. Here's the type definition:My understanding is that
TracingHandler
was removed in Sentry 8, and incoming trace requests are automatically instrumented. Should this be removed?Here's a sample
SamplingContext
I'm seeing:This provides a lot of the HTTP request context, but not important items like headers. How can I get access to those?
I tried adding a request hook to the HTTP instrumentation, but that appears to be called after
tracesSampler
.Beta Was this translation helpful? Give feedback.
All reactions