test: basic tests

Author: bruno-garcia

.editorconfig

@@ -8,7 +8,11 @@ insert_final_newline = true
 [*.md]
 trim_trailing_whitespace = false
 
-[*.{java,kt,kts}]
+[*.java]
+indent_size = 2
+charset = utf-8
+
+[*.{kt,kts}]
 indent_size = 4
 charset = utf-8
 

sentry-core/src/main/java/io/sentry/NoOpSentryClient.java

@@ -3,14 +3,17 @@
 import java.util.UUID;
 
 class NoOpSentryClient implements ISentryClient {
+
+  private static final UUID emptyId = UUID.fromString("00000000-0000-0000-0000-000000000000");
+
   @Override
   public boolean isEnabled() {
     return false;
   }
 
   @Override
   public UUID captureEvent(SentryEvent event) {
-    return UUID.fromString("00000000-0000-0000-0000-000000000000");
+    return emptyId;
   }
 
   @Override

sentry-core/src/test/java/io/sentry/NoOpSentryClientTest.kt

@@ -0,0 +1,23 @@
+package io.sentry
+
+import java.util.UUID
+import kotlin.test.Test
+import kotlin.test.assertFalse
+import kotlin.test.assertEquals
+
+class NoOpSentryClientTest {
+    private var sut: NoOpSentryClient = NoOpSentryClient()
+
+    @Test
+    fun `client is always disabled`() = assertFalse(sut.isEnabled)
+
+    @Test
+    fun `captureEvent is returns empty UUID`() =
+        assertEquals(UUID.fromString("00000000-0000-0000-0000-000000000000"), sut.captureEvent(null))
+
+    @Test
+    fun `close does not affect captureEvent`() {
+        sut.close()
+        assertEquals(UUID.fromString("00000000-0000-0000-0000-000000000000"), sut.captureEvent(null))
+    }
+}

sentry-core/src/test/java/io/sentry/SampleDsn.kt

@@ -0,0 +1,5 @@
+package io.sentry
+
+// Legacy DSN includes a secret. Sentry 8 and older will require it.
+const val dsnStringLegacy: String = "https://d4d82fc1c2c4032a83f3a29aa3a3aff:[email protected]:65535/2147483647"
+const val dsnString: String = "https://[email protected]:65535/2147483647"

sentry-core/src/test/java/io/sentry/SentryClientTest.kt

@@ -0,0 +1,62 @@
+package io.sentry
+
+import kotlin.test.Test
+import kotlin.test.assertFalse
+import kotlin.test.Ignore
+import kotlin.test.assertTrue
+
+class SentryClientTest {
+
+    class Fixture {
+        var sentryOptions: SentryOptions = SentryOptions().apply {
+            dsn = dsnString
+        }
+        fun getSut() = SentryClient(sentryOptions)
+    }
+
+    private val fixture: Fixture = Fixture()
+
+    @Test
+    fun `when fixture is unchanged, client is enabled`() {
+        val sut = fixture.getSut()
+        assertTrue(sut.isEnabled)
+    }
+
+    @Test
+    @Ignore("Not implemented")
+    fun `when dsn is an invalid string, client is disabled`() {
+        fixture.sentryOptions.dsn = "invalid-dsn"
+        val sut = fixture.getSut()
+        assertFalse(sut.isEnabled)
+    }
+
+    @Test
+    @Ignore("Not implemented")
+    fun `when dsn is null, client is disabled`() {
+        fixture.sentryOptions.dsn = null
+        val sut = fixture.getSut()
+        assertFalse(sut.isEnabled)
+    }
+
+    @Test
+    fun `when dsn without private key is valid, client is enabled`() {
+        fixture.sentryOptions.dsn = dsnString
+        val sut = fixture.getSut()
+        assertTrue(sut.isEnabled)
+    }
+
+    @Test
+    fun `when dsn with secret is valid, client is enabled`() {
+        fixture.sentryOptions.dsn = dsnStringLegacy
+        val sut = fixture.getSut()
+        assertTrue(sut.isEnabled)
+    }
+
+    @Test
+    fun `when client is closed, client gets disabled`() {
+        val sut = fixture.getSut()
+        assertTrue(sut.isEnabled)
+        sut.close()
+        assertFalse(sut.isEnabled)
+    }
+}