-
-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v9] Remove old user feedback api #2686
base: v9
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v9 #2686 +/- ##
==========================================
+ Coverage 88.31% 88.46% +0.15%
==========================================
Files 262 261 -1
Lines 8911 8855 -56
==========================================
- Hits 7870 7834 -36
+ Misses 1041 1021 -20 ☔ View full report in Codecov by Sentry. |
@denrase I updated the hive mocks with the build_runner but now the hive tests are failing because something's wrong with the generated mocks, have you encountered this as well? |
@buenaflor Yup, had the same issue yesterday, just check my commits here: https://github.com/getsentry/sentry-dart/pull/2675/commits |
@denrase how did you fix it? re-generating the mock doesn't seem to work in my case |
@buenaflor Added the compiler directives back in that were deleted (see diff or commits) and also in hive mocks, there is some custom code which i added back in after re-generation overrode it. |
📜 Description
💡 Motivation and Context
Closes #2682
💚 How did you test it?
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps