Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replay: Masking not working #2550

Open
xmooncake opened this issue Jan 3, 2025 · 0 comments
Open

Replay: Masking not working #2550

xmooncake opened this issue Jan 3, 2025 · 0 comments

Comments

@xmooncake
Copy link

Platform

Flutter Mobile iOS

Obfuscation

Enabled

Debug Info

Enabled

Doctor

[✓] Flutter (Channel stable, 3.19.6, on macOS 15.1 24B83 darwin-arm64, locale en-US)
[✓] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
[✓] Xcode - develop for iOS and macOS (Xcode 16.2)
[✗] Chrome - develop for the web (Cannot find Chrome executable at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome)
! Cannot find Chrome. Try setting CHROME_EXECUTABLE to a Chrome executable.
[✓] Android Studio (version 2024.1)
[✓] VS Code (version 1.96.1)
[✓] Connected device (3 available)
[✓] Network resources

Version

8.12.0

Steps to Reproduce

Configuration:

 await SentryFlutter.init(
    (options) {
      options.dsn = ''

      // Session replay
      options.experimental.replay.sessionSampleRate = 1.0;
      options.experimental.replay.onErrorSampleRate = 1.0;

      options.experimental.privacy;
      options.experimental.privacy.maskAllText = true;
    },
    appRunner: () => runApp(
      const ProviderScope(
        observers: [StateLogger()],
        child: MyApp(),
      ),
    ),
  );

Masking wrapper:

class OccludeWrapper extends SentryMask {
  const OccludeWrapper(
    super.child, {
    super.key,
  });

  @override
  Widget build(BuildContext context) => child;
}

Expected Result

Expected to have input fields hidden according to documentation:

By default, our Session Replay SDK masks all text content, images, and user input, giving you heightened confidence that no
sensitive data will leave the device.

Actual Result

Neither the default masking nor the custom wrapper seem to have any effect, everything is still shown on the recordings

Are you willing to submit a PR?

None

@github-project-automation github-project-automation bot moved this to Needs Discussion in Mobile & Cross Platform SDK Jan 3, 2025
@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 3 Jan 3, 2025
@xmooncake xmooncake changed the title Masking not working Replay: Masking not working Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for: Product Owner
Status: Needs Discussion
Development

No branches or pull requests

2 participants