Add login command
#74
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
lbergnehr
force-pushed
the
main
branch
2 times, most recently
from
f0202e9 to
c259af5
Compare
1. Check for the existence of `~/.azure`, which signals we're already logged in using some means. 2. Check the environment for a service principal as defined by the environment variables `AZURE_CLIENT_ID`, `AZURE_TENANT_ID`, and `AZURE_CLIENT_SECRET`. 3. Check the `AZURE_CLIENT_ID` environment variable for the client ID of a user-assigned managed identity. 4. Use the system-assigned managed identity for the Azure resource if it's enabled. Signed-off-by: Leo Bergnéhr <[email protected]>
|
It think it would be beneficial to add some examples to the documentation showing the different ways to login |
| func (c *LoginCommand) GetFlags() builder.Flags { | ||
| flags := builder.Flags{} | ||
|
|
||
| if _, err := os.Stat(filepath.Join(os.Getenv("HOME"), ".azure")); err == nil { |
There was a problem hiding this comment.
It would be great to document what files is needed, as a lot of file exist in the directory locally
Comment on lines
+49
to
+51
| if _, err := os.Stat(filepath.Join(os.Getenv("HOME"), ".azure")); err == nil { | ||
| return flags | ||
| } |
There was a problem hiding this comment.
Indentation doesn't match the rest of the file
| } | ||
|
|
||
| if os.Getenv("AZURE_CLIENT_ID") != "" && os.Getenv("AZURE_CLIENT_SECRET") != "" && os.Getenv("AZURE_TENANT_ID") != "" { | ||
| // Add flags for service principal authentication |
There was a problem hiding this comment.
The version of the AZ CLI, v2.67.0, I have installed also requires the --service-principal flag when logging in as a service principal, so it might depend on the AZ CLI version what is needed here.
As it is possible to choose the AZ CLI version to install, we should think about what to do with different versions (if they behave differently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #33.
~/.azure, which signals we're alreadylogged in using some means.
environment variables
AZURE_CLIENT_ID,AZURE_TENANT_ID, andAZURE_CLIENT_SECRET.AZURE_CLIENT_IDenvironment variable for the client ID ofa user-assigned managed identity.
it's enabled.
.azuredirectory.