Block Selector not closing after pasting block #7087
Comments
fnwbr
added a commit
to fnwbr/kirby
that referenced
this issue
Mar 26, 2025
Fixes getkirby#7087 Add a `close` method to the `BlockSelector` component to fix the issue of the block selector not closing after pasting a block. * Add a `close` method in the `methods` section of `panel/src/components/Forms/Blocks/BlockSelector.vue`. * Call the `close` method after pasting a block to close the block selector. * Emit a `cancel` event in the `close` method to handle the closing of the block selector. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/getkirby/kirby/issues/7087?shareId=XXXX-XXXX-XXXX-XXXX).
|
Seems like nobody noticed this for a while given that (1) the pasting actually works and (2) there's a feedback message. |
distantnative
pushed a commit
that referenced
this issue
Mar 30, 2025
Fixes #7087 Add a `close` method to the `BlockSelector` component to fix the issue of the block selector not closing after pasting a block. * Add a `close` method in the `methods` section of `panel/src/components/Forms/Blocks/BlockSelector.vue`. * Call the `close` method after pasting a block to close the block selector. * Emit a `cancel` event in the `close` method to handle the closing of the block selector. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/getkirby/kirby/issues/7087?shareId=XXXX-XXXX-XXXX-XXXX).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When the block selector is open and I paste a block, the block selector stays opens. The dev tools console shows this error:
Uncaught TypeError: this.close is not a function.Expected behavior
Pasting should close the block selector, according to this line:
https://github.com/getkirby/kirby/blob/main/panel/src/components/Forms/Blocks/BlockSelector.vue#L124
To reproduce
Your setup
Kirby Version
4.6.1 and 5.0.0-beta.4
Your system (please complete the following information)
The text was updated successfully, but these errors were encountered: