Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.1: "is_file(): Passing null to parameter #1 ($filename) of type string is deprecated" #4032

Closed
HYR opened this issue Dec 10, 2021 · 1 comment
Assignees
Milestone

Comments

@HYR
Copy link
Contributor

HYR commented Dec 10, 2021

Description

CleanShot 2021-12-10 at 09 46 33@2x

I have 3 snippet calls for prepending or appending code as needed. None of these snippets exist until I need them. Until now this method has worked well. When upgrading to PHP 8.1 I get the following error:

CleanShot 2021-12-10 at 10 10 17@2x

With PHP 8.1 the deprecation shown in the screenshot above is not handled by Kirby as of version 3.6.1.1.

Expected behavior
I expect Kirby to ignore snippets that don't exist, without producing an error.

To reproduce

  1. Be sure to have PHP 8.1 installed
  2. In PHP call a snippet that doesn't exist.
  3. You should see the Error

Your setup

Kirby Version
Kirby 3.6.1.1

@afbora
Copy link
Member

afbora commented Dec 12, 2021

@afbora afbora closed this as completed Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants