Make Widget check status of Ping before sending API request

[ngoc-minh-do]

Description

In my services.yaml file, I have some service definition like this:

- Plex:
    icon: plex
    href: https://plex.ngoclab.com
    ping: 192.168.0.x
    widget:
      type: plex
      url: https://192.168.0.x:32400
      key: xxxxxx

If the service is turned off and I check the homepage logs, I always see errors like this:

[2025-01-20T00:27:56.105Z] error: <httpProxy> Error calling https://192.168.0.x:32400/status/sessions...
[2025-01-20T00:27:56.106Z] error: <httpProxy> [
  500,
  Error: connect EHOSTUNREACH 192.168.0.x:32400
      at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1555:16) {
    errno: -113,
    code: 'EHOSTUNREACH',
    syscall: 'connect',
    address: '192.168.0.x',
    port: 32400
  }
]

I think it would be better to check the ping status before making any further requests, including those related to the widget. What do you all think?

homepage version

v0.10.9

Installation method

Docker

Configuration

No response

Container Logs

No response

Browser Logs

No response

Troubleshooting

No

[shamoon]

That sounds like it would make requests very slow.

If youre using docker you can use automatic service discovery with docker labels, that way containers that are offline wont even show up

[ngoc-minh-do]

What do you mean it would make requests very slow

I thought that because I set up both ping and widget, there will be 2 request.
So if we have some kind of additional logic to check the status of ping before any further request (Eg: widget)
=> Number of request will be reduced, number of error will be reduced, faster response

In my mind, the logic can be something like this

let isServerOn = true;

if (`ping is set`) {
  isServerOn = doPing();
}

if (isServerOn && `widget is set`) {
  fetchDataForWidget();
}

[shamoon]

But then every request that succeeds would also be preceded by a totally unnecessary ping

[ngoc-minh-do]

As described in example code, doPing() only executed when ping is set condition is met (by default isServerOn is true)
That mean there is nothing unnecessary, it depends on user setting