Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch mode for grit patterns test #51

Closed
morgante opened this issue Mar 22, 2024 · 19 comments · Fixed by #298
Closed

Watch mode for grit patterns test #51

morgante opened this issue Mar 22, 2024 · 19 comments · Fixed by #298

Comments

@morgante
Copy link
Contributor

morgante commented Mar 22, 2024

We would like to have a watch mode for grit patterns test --watch.

Watch mode should be similar to other testing/CLI tools that offer a watch mode: when files change, re-run tests.

Acceptance criteria

  • Watch mode should watch for file changes to any patterns in the .grit directory and automatically re-run those tests
  • If a file changes, only the affected patterns should be re-run. Ex. if I edit this file then only that pattern test should re-run.
  • You will also need to account for pattern dependencies. Ex. if https://github.com/getgrit/stdlib/blob/main/.grit/patterns/js/imports.grit is edited then any patterns which use the ensure_import_from pattern should be re-run. Utilities like this can be leveraged for walking the call graph
  • At least 2 tests should be included, including ideally at least one integration test of the final binary like we do here.
@morgante
Copy link
Contributor Author

/bounty $250

Copy link

algora-pbc bot commented Mar 22, 2024

💎 $250 bounty • Grit

Steps to solve:

  1. Start working: Comment /attempt #51 with your implementation plan
  2. Submit work: Create a pull request including /claim #51 in the PR body to claim the bounty
  3. Receive payment: 100% of the bounty is received 2-5 days post-reward. Make sure you are eligible for payouts

Thank you for contributing to getgrit/gritql!

Add a bountyShare on socials

Attempt Started (GMT+0) Solution
🟢 @el-buku Mar 22, 2024, 12:42:53 PM WIP
🟢 @Sambit003 Mar 25, 2024, 9:57:36 AM WIP
🟢 @Ashu999 Apr 24, 2024, 6:18:34 AM #298

@el-buku
Copy link

el-buku commented Mar 22, 2024

/attempt 51

@webbdays
Copy link

@el-buku
any progress.
still on this?

@el-buku
Copy link

el-buku commented Mar 22, 2024 via email

@Sambit003
Copy link

Sambit003 commented Mar 25, 2024

/attempt #51

@vivasvan1
Copy link

@Sambit003 @el-buku
Hi there fellas,

Are you working on this?
If yes, let me know if you interested in working togather.
If no, I would like to attempt it.

Hope u have a nice day.

@Ashu999
Copy link
Contributor

Ashu999 commented Apr 24, 2024

/attempt #51

Copy link

algora-pbc bot commented May 1, 2024

💡 @Ashu999 submitted a pull request that claims the bounty. You can visit your bounty board to reward.

@varshith257
Copy link

varshith257 commented Jul 8, 2024

@morgante Is this issue open to grab?
Have some good approach in my mind to add --watcher with less code

@morgante
Copy link
Contributor Author

morgante commented Jul 8, 2024

@varshith257 No, this is already complete and I will award the bounty to @Ashu999. Feel free to open a PR with an improved approach if you have one in mind.

@varshith257
Copy link

@morgante It seems already PR is merged. How my work reflects it and rewarded?

@morgante
Copy link
Contributor Author

morgante commented Jul 8, 2024

@varshith257 You did no work for that PR. Why would you be rewarded for something you made no contributions to?

@varshith257
Copy link

@morgante I think we misunderstood. You said to open a PR with my approach. So that's I am asking for 😅

@morgante
Copy link
Contributor Author

morgante commented Jul 8, 2024

@varshith257 This is an open source repository, under a permissive license. If you have a superior approach, feel free to provide a PR. We will not be paying for every PR.

If you expect every single PR on every repo will be "compensated" you do not understand the ethos of open source.

@varshith257
Copy link

Hey @morgante I got you.There are some orgs bountied for multiple PRs as one the case here. So thought in that way. Ok, I will check @Ashu999 implementation and will propose my improvements 😄

@varshith257
Copy link

varshith257 commented Jul 8, 2024

PS: I have contributed to different organisations as OS Contributer. But it's now time to upgrade my old Windows 10 PC. So searching some cool bounties which I can get with them and buy it by my birthday on July 25(makes me confident of reaching my target too and get ahead of cracking further goals)

@morgante
Copy link
Contributor Author

morgante commented Jul 8, 2024

Thanks @varshith257, I appreciate your understanding. I'm also happy to awards tips for good contributions and will consider opening more bounties in the future.

Copy link

algora-pbc bot commented Jul 8, 2024

🎉🎈 @Ashu999 has been awarded $250! 🎈🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants