Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[add-resource] New Plugin: Umami Analytics #3836

Open
chraebsli opened this issue May 28, 2024 · 2 comments
Open

[add-resource] New Plugin: Umami Analytics #3836

chraebsli opened this issue May 28, 2024 · 2 comments

Comments

@chraebsli
Copy link

I would like to add my new plugin to the Grav Repository.
Here are the project details: Crabston/grav-plugin-umami-analytics

@pamtbaau
Copy link
Contributor

Just a quick note:
Assets should be added using the Asset Manager instead of injecting it in the generated HTML using preg_replace.

Assets can ben added when, or after, the onAssetsInitialized event is/has been fired.

@chraebsli
Copy link
Author

Thanks for the feedback! I'll update it soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants