-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown not processed in checkbox #161
Comments
Browsing through the History it looks like the checkbox (and possibly other field overrides) are missing a lot of the recent fixes. The only real difference I see here is the addition of I guess the checkbox template can be completely removed then? Edit: No, it cannot be removed yet, but the templates can be improved a lot. I've updated them here: |
I'd like to see this fix in the next update - it seems a shame to have to overwrite it in a child theme. |
I agree, maybe @NicoHood can create a pull request? Or maybe outline what's needed to fix this, then maybe I can create a pull request based on that info. |
I see you have many contributions in your own fork, could you please merge them with upstream? Thanks! |
I posted a lot PRs, but it doesnt seem anybody cares about this theme. |
Hi @rhukster, sorry to tag you in this thread. But it seems some very useful additions for this theme are not merged yet. Is it possible to review and merge them by someone from the Grav team? |
I recently noticed, that checkbox form fields are not process, even when markdown is enabled.
There was a PR merged that fixes this:
getgrav/grav-plugin-form#233
But the theme overrides this template here:
https://github.com/getgrav/grav-theme-quark/blob/develop/templates/forms/fields/checkbox/checkbox.html.twig
Now I am wondering, why does this template even exist? Should we fix it, or should we remove it?
Here is a diff of the current files, to quickly visualize it:
The text was updated successfully, but these errors were encountered: