Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grav debug bar fails to show #24

Open
marshmn opened this issue Apr 17, 2019 · 2 comments · May be fixed by #27
Open

Grav debug bar fails to show #24

marshmn opened this issue Apr 17, 2019 · 2 comments · May be fixed by #27

Comments

@marshmn
Copy link

marshmn commented Apr 17, 2019

Since the update from v1.4 -> v1.5 of this theme the Grav debug bar no longer shows. A number of messages appear in the console, the first of which is:

Uncaught ReferenceError: jQuery is not defined
    at debugbar.js:4

I think that this may be occurring due to the moving around of where assets are loaded within the template. It looks as though jQuery is now loaded in the 'bottom' group of assets and I think that the debug bar is trying to load it's JavaScript before jQuery.

I think that this may also cause some issues for other plugins etc. which may require jQuery to be loaded earlier.
@marshmn
Copy link
Author

marshmn commented Apr 17, 2019

I've played around locally with moving the jQuery loading into the 'head' group - which does appear to fix this problem (and a couple of other issues I saw with other plugins). I'm not sure if this is the preferred approach though?

@rhukster
Copy link
Member

jquery does like to be loaded in head.. i think its fine to change it to that.

@marshmn marshmn linked a pull request Apr 17, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix jQuery loading marshmn/grav-theme-agency
2 participants
@rhukster @marshmn