-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some issues after Grav v1.1.x update #6
Comments
Did you download the package from the releases? |
Hi. Yes I downloaded the skeleton from the releases here: https://getgrav.org/downloads/skeletons https://getgrav.org/downloads/skeletons
|
Ok so, the skeleton is including Admin, but Admin 1.1 instead of the stable release. Should we drop including Admin? Must be the only skeleton doing this. I tested the class on the h3. Works fine. You have a trailing I fixed the Landio theme form issue on medium screens. I cannot find the LOGIN_PLUGIN.BTN_LOGIN string, can you make a screenshot? Did you add some twig edit? The form worked fine for me, I got the email. Please use a testing SMTP service to test emails, don't rely on PHP mail() (which is the default of the email plugin, but not always works due to various reasons). See https://github.com/getgrav/grav-plugin-email#testing-emails |
I did try this with the skeleton download, Admin should not be included in the first place, that caused the other problems. @rhukster we should remove this, and recompile the skeleton? As it's getting Admin 1.1. Also now can include the landio theme update. I can get the "Contact us" working. Make sure you enabled Markdown Extra in the config. I fixed the language strings in the theme repository: https://github.com/getgrav/grav-theme-landio/commits/develop they were inverted. |
You can get around this by installing the older admin plugin (uninstalling the version that came with the skeleton first) |
Just removed |
Hi there,
This sceleton is not working as is. Users are forced to upgrade to Grav v1.1.x.
Classes within markup are not working and show up on the rendered page.
Instead of:
### Contact us {.text-center .m-b-lg} )
I had to use pure HTML:
<h3 class="text-center m-b-lg">Contact us</h3>
For centering the contact-form also on medium format screens I added the class
col-md-offset-2
to the corresponding divs.Issue with the navigation:
rightmost entry reads as
LOGIN_PLUGIN.BTN_LOGIN
. Seems there is some issue with fetching the variable value.I did not get the contact form to send emails. Crosschecking my mail settings with another sceleton (ceevee) worked like charm. Have no clue how to solve this.
This is a great template and I'd like to use this, but I'd need to have this contact form working.
Best regards.
Peter
The text was updated successfully, but these errors were encountered: