Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing translations in JSON sitemap #100

Open
bitstarr opened this issue Nov 3, 2021 · 2 comments
Open

Missing translations in JSON sitemap #100

bitstarr opened this issue Nov 3, 2021 · 2 comments

Comments

@bitstarr
Copy link

bitstarr commented Nov 3, 2021

I am using translation strings for some page titles in my project. In the sitemap.json these titles will not be translated.
Can we have a config flag to enable translation?

example json

@Karmalakas
Copy link

Karmalakas commented Nov 3, 2021

What's the use case here? Shouldn't title come from page frontmatter header, which should be different for different languages? That's kind of a user input field rather than some code coming from a script 🤔

@bitstarr
Copy link
Author

bitstarr commented Nov 3, 2021

I don't use the admin plugin in this scenario. Generic pages like contact or search result pages use translation strings in frontmatter and will be translated template wise.

Using those strings is useful especially with a contact form. You don't need multiple markdown files for one page, which reduced the need to change multiple places in case you modify the form.

Yes, it's pretty non standard but kind of convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants