Use arguments file to avoid long classpaths. #402 (#413)

* Use argumetns file to avoid long classpaths. #402

Signed-off-by: BugDiver <[email protected]>

* Running tests with java 12

Signed-off-by: BugDiver <[email protected]>

Author: Vinay Shankar Shukla

.github/workflows/tests.yml

@@ -44,30 +44,11 @@ jobs:
       - name: Setup java
         uses: actions/setup-java@v1
         with:
-          java-version: '1.8'
+          java-version: '12.x.x'
 
-      - name: Setup go 1.13.1
-        uses: actions/setup-go@v1
+      - uses: bugdiver/setup-gauge@master
         with:
-          go-version: 1.13.1
-
-      - name: Install gauge on linux
-        if: matrix.os != 'windows-latest'
-        run: |
-          git clone --depth=1 https://github.com/getgauge/gauge
-          cd gauge
-          go run build/make.go --verbose
-          go run build/make.go --install --prefix=/tmp/
-          echo "::add-path::/tmp/bin"
-
-      - name: Install gauge (windows)
-        if: matrix.os == 'windows-latest'
-        run: |
-          git clone --depth=1 https://github.com/getgauge/gauge
-          cd gauge
-          go run build/make.go --verbose
-          go run build/make.go --install
-          echo "::add-path::C:\Program Files\gauge\bin"
+          gauge-version: master
 
       - name: Install html report
         run: |
@@ -80,6 +61,7 @@ jobs:
         if: matrix.os != 'windows-latest'
         run: |
           ./build.sh forceinstall
+        shell: bash
 
       - name: Install Gauge Java plugin from source
         if: matrix.os == 'windows-latest'
@@ -94,18 +76,11 @@ jobs:
         run: |
           git clone --depth=1 https://github.com/getgauge/gauge-tests
 
-      - name: Run FTs on linux
-        if: matrix.os != 'windows-latest'
+      - name: Run FTs
         run: |
           cd gauge-tests
           ./gradlew clean javaFT
-
-      - name: Run FTs on windows
-        if: matrix.os == 'windows-latest'
-        shell: pwsh
-        run: |
-          cd gauge-tests
-          .\gradlew.bat clean javaFT
+        shell: bash
 
       - uses: actions/upload-artifact@v1
         if: failure()
@@ -132,25 +107,11 @@ jobs:
       - name: Setup java
         uses: actions/setup-java@v1
         with:
-          java-version: '1.8'
-
-      - name: Install gauge on linux
-        if: matrix.os != 'windows-latest'
-        run: |
-          git clone https://github.com/getgauge/gauge
-          cd gauge
-          go run build/make.go --verbose
-          go run build/make.go --install --prefix=/tmp/
-          echo "::add-path::/tmp/bin"
+          java-version: '12.x.x'
 
-      - name: Install gauge (windows)
-        if: matrix.os == 'windows-latest'
-        run: |
-          git clone https://github.com/getgauge/gauge
-          cd gauge
-          go run build/make.go --verbose
-          go run build/make.go --install
-          echo "::add-path::C:\Program Files\gauge\bin"
+      - uses: bugdiver/setup-gauge@master
+        with:
+          gauge-version: master
 
       - name: Install Gauge Java plugin from source
         if: matrix.os != 'windows-latest'

bin/launcher.ps1

@@ -2,25 +2,34 @@ Param(
   [String]$TaskName # The name of the task to run
 )
 
-$DefaultBuildDir = "gauge_bin"
-$PluginDir = Get-Location
-$global:classpath = $env:gauge_custom_classpath
-Set-Location $env:GAUGE_PROJECT_ROOT
-
 $javaCommand = "java"
 $javacCommand = "javac"
 
 if ("$env:gauge_java_home" -ne "") {
-    $javaCommand = "$env:gauge_java_home\bin\$javaCommand"
-    $javacCommand = "$env:gauge_java_home\bin\$javacCommand"
+  $javaCommand = "$env:gauge_java_home\bin\$javaCommand"
+  $javacCommand = "$env:gauge_java_home\bin\$javacCommand"
 }
 elseif ("$env:JAVA_HOME" -ne "") {
-    $javaCommand = "$env:JAVA_HOME\bin\$javaCommand"
-    $javacCommand = "$env:JAVA_HOME\bin\$javacCommand"
+  $javaCommand = "$env:JAVA_HOME\bin\$javaCommand"
+  $javacCommand = "$env:JAVA_HOME\bin\$javacCommand"
 }
 
+$verison = (Get-Command $javaCommand | Select-Object -ExpandProperty Version).Major | Out-String
+if ( "$verison" -as [int] -lt 9 ) {
+  Write-Output "This version of the plugin does not support java version < 1.9";
+  Write-Output "Please upgrade your java version or stick to an older version of gauge-java."
+  exit 1;
+}
+
+
+$DefaultBuildDir = "gauge_bin"
+$PluginDir = Get-Location
+$global:classpath = $env:gauge_custom_classpath
+Set-Location $env:GAUGE_PROJECT_ROOT
+
+
 function AddRunnerInClassPath {
-  $global:classpath = $global:classpath + "$PluginDir\*" + ";" + "$PluginDir\libs\*"
+  $global:classpath += "$PluginDir\libs\*"
 }
 
 function GetAdditionalPath() {
@@ -87,6 +96,17 @@ function AddClassPathRequiredForExecution() {
   }
 }
 
+function EscapeSpaceInClasspath {
+  $classpath = $global:classpath.Split(";")
+  $global:classpath = ""
+  foreach ($cp in $classpath.Split(";")) {
+      if ($cp.Contains(" ") ) {
+        $cp = "`"$cp`"" -replace '\\','\\'
+      }
+      $global:classpath+="$cp;"
+  }
+}
+
 $tasks = @{ }
 $tasks.Add('init', {
     if ("$global:classpath" -eq "" ) { AddRunnerInClassPath }
@@ -100,12 +120,15 @@ $tasks.Add('start', {
       AddRunnerInClassPath
       AddClassPathRequiredForExecution
     }
-    $env:CLASSPATH = $global:classpath
     if ("$env:GAUGE_DEBUG_OPTS" -ne "" ) {
       $debugArgs = "-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=$env:GAUGE_DEBUG_OPTS,timeout=25000"
       Write-Output "`nRunner Ready for Debugging"
     }
-    & $javaCommand `"-Dfile.encoding=UTF-8`" $debugArgs $env:gauge_jvm_args com.thoughtworks.gauge.GaugeRuntime --start
+    EscapeSpaceInClasspath
+    $random = (Get-Random)
+    $targetFile = Join-Path "$env:TEMP" "$random.txt"
+    Write-Output "-cp $global:classpath `"-Dfile.encoding=UTF-8`" $debugArgs $env:gauge_jvm_args com.thoughtworks.gauge.GaugeRuntime --start" | Out-File $targetFile -Append -Encoding default
+    & $javaCommand "@$targetFile"
     exit
   })
 

bin/launcher.sh

@@ -19,6 +19,13 @@ elif [ ! -z "${JAVA_HOME}" ]; then
     javacCommand="${JAVA_HOME}/bin/${javacCommand}"
 fi
 
+version=$("$javaCommand" -version 2>&1 | awk -F '"' '/version/ {print $2}')
+if [[ "$version" < "1.9" ]]; then
+    echo -e "This version of gauge-java plugin does not support Java versions < 1.9";
+    echo -e "Please upgrade your Java version or use a version of gauge-java <= v0.7.4"
+    exit 1;
+fi
+
 cd "$project_root"
 
 function get_abs() {
@@ -118,7 +125,9 @@ function start() {
         args="${args} -agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=${GAUGE_DEBUG_OPTS},timeout=25000"
         echo -e "\nRunner Ready for Debugging"
     fi
-    CLASSPATH="${class_path}" $javaCommand ${args} com.thoughtworks.gauge.GaugeRuntime --start
+    target_file="$TMPDIR$RANDOM-$RANDOM.txt"
+    echo "-cp \"${class_path}\" ${args} com.thoughtworks.gauge.GaugeRuntime --start" >$target_file
+    $javaCommand @$target_file
 }
 
 function init() {