feat: Implement ATOM feeds for posts and comments (#1287)

Adds ATOM feed support, providing two new endpoints:
- A global feed for all posts at /feed/global.atom
- Per-post feeds for comments at /feed/posts/<post_id>.atom

Includes settings to enable/disable feeds and integrates feed discovery and links into the UI.

Fixes #1286

Author: afeuerstein

app/actions/tenant.go

@@ -15,7 +15,7 @@ import (
 	"github.com/getfider/fider/app/pkg/validate"
 )
 
-//CreateTenant is the input model used to create a tenant
+// CreateTenant is the input model used to create a tenant
 type CreateTenant struct {
 	Token           string `json:"token"`
 	Name            string `json:"name"`
@@ -89,27 +89,27 @@ func (action *CreateTenant) Validate(ctx context.Context, user *entity.User) *va
 	return result
 }
 
-//GetEmail returns the email being verified
+// GetEmail returns the email being verified
 func (action *CreateTenant) GetEmail() string {
 	return action.Email
 }
 
-//GetName returns the name of the email owner
+// GetName returns the name of the email owner
 func (action *CreateTenant) GetName() string {
 	return action.Name
 }
 
-//GetUser returns the current user performing this action
+// GetUser returns the current user performing this action
 func (action *CreateTenant) GetUser() *entity.User {
 	return nil
 }
 
-//GetKind returns EmailVerificationKindSignUp
+// GetKind returns EmailVerificationKindSignUp
 func (action *CreateTenant) GetKind() enum.EmailVerificationKind {
 	return enum.EmailVerificationKindSignUp
 }
 
-//UpdateTenantSettings is the input model used to update tenant settings
+// UpdateTenantSettings is the input model used to update tenant settings
 type UpdateTenantSettings struct {
 	Logo           *dto.ImageUpload `json:"logo"`
 	Title          string           `json:"title"`
@@ -175,7 +175,7 @@ func (action *UpdateTenantSettings) Validate(ctx context.Context, user *entity.U
 	return result
 }
 
-//UpdateTenantAdvancedSettings is the input model used to update tenant advanced settings
+// UpdateTenantAdvancedSettings is the input model used to update tenant advanced settings
 type UpdateTenantAdvancedSettings struct {
 	CustomCSS string `json:"customCSS"`
 }
@@ -190,18 +190,22 @@ func (action *UpdateTenantAdvancedSettings) Validate(ctx context.Context, user *
 	return validate.Success()
 }
 
-//UpdateTenantPrivacy is the input model used to update tenant privacy settings
-type UpdateTenantPrivacy struct {
-	IsPrivate bool `json:"isPrivate"`
+// UpdateTenantPrivacySettings is the input model used to update tenant privacy settings
+type UpdateTenantPrivacySettings struct {
+	IsPrivate     bool `json:"isPrivate"`
+	IsFeedEnabled bool `json:"isFeedEnabled"`
 }
 
 // IsAuthorized returns true if current user is authorized to perform this action
-func (action *UpdateTenantPrivacy) IsAuthorized(ctx context.Context, user *entity.User) bool {
+func (action *UpdateTenantPrivacySettings) IsAuthorized(ctx context.Context, user *entity.User) bool {
 	return user != nil && user.Role == enum.RoleAdministrator
 }
 
 // Validate if current model is valid
-func (action *UpdateTenantPrivacy) Validate(ctx context.Context, user *entity.User) *validate.Result {
+func (action *UpdateTenantPrivacySettings) Validate(ctx context.Context, user *entity.User) *validate.Result {
+	if action.IsPrivate && action.IsFeedEnabled {
+		return validate.Failed("Feed can not be enabled when set to private.")
+	}
 	return validate.Success()
 }
 

app/cmd/routes.go

@@ -44,6 +44,17 @@ func routes(r *web.Engine) *web.Engine {
 		assets.Static("/assets/*filepath", "dist")
 	}
 
+	feed := r.Group()
+	{
+		feed.Use(middlewares.CORS())
+		feed.Use(middlewares.WebSetup())
+		feed.Use(middlewares.Tenant())
+		feed.Use(middlewares.ClientCache(5 * time.Minute))
+
+		feed.Get("/feed/global.atom", handlers.GlobalFeed())
+		feed.Get("/feed/posts/:path", handlers.CommentFeed())
+	}
+
 	r.Use(middlewares.Session())
 
 	r.Get("/robots.txt", handlers.RobotsTXT())
@@ -164,7 +175,7 @@ func routes(r *web.Engine) *web.Engine {
 		ui.Get("/_api/admin/webhook/props/:type", handlers.GetWebhookProps())
 		ui.Post("/_api/admin/settings/general", handlers.UpdateSettings())
 		ui.Post("/_api/admin/settings/advanced", handlers.UpdateAdvancedSettings())
-		ui.Post("/_api/admin/settings/privacy", handlers.UpdatePrivacy())
+		ui.Post("/_api/admin/settings/privacy", handlers.UpdatePrivacySettings())
 		ui.Post("/_api/admin/settings/emailauth", handlers.UpdateEmailAuthAllowed())
 		ui.Post("/_api/admin/oauth", handlers.SaveOAuthConfig())
 		ui.Post("/_api/admin/roles/:role/users", handlers.ChangeUserRole())

app/handlers/admin.go

@@ -92,16 +92,17 @@ func UpdateAdvancedSettings() web.HandlerFunc {
 	}
 }
 
-// UpdatePrivacy update current tenant's privacy settings
-func UpdatePrivacy() web.HandlerFunc {
+// UpdatePrivacySettings update current tenant's privacy settings
+func UpdatePrivacySettings() web.HandlerFunc {
 	return func(c *web.Context) error {
-		action := new(actions.UpdateTenantPrivacy)
+		action := new(actions.UpdateTenantPrivacySettings)
 		if result := c.BindTo(action); !result.Ok {
 			return c.HandleValidation(result)
 		}
 
 		updateSettings := &cmd.UpdateTenantPrivacySettings{
-			IsPrivate: action.IsPrivate,
+			IsPrivate:     action.IsPrivate,
+			IsFeedEnabled: action.IsFeedEnabled,
 		}
 		if err := bus.Dispatch(c, updateSettings); err != nil {
 			return c.Failure(err)

app/handlers/admin_test.go

@@ -134,7 +134,7 @@ func TestUpdateSettingsHandler_RemoveLogo(t *testing.T) {
 	ExpectHandler(&cmd.UploadImage{}).CalledOnce()
 }
 
-func TestUpdatePrivacyHandler(t *testing.T) {
+func TestUpdatePrivacySettingsHandler(t *testing.T) {
 	RegisterT(t)
 
 	var updateCmd *cmd.UpdateTenantPrivacySettings
@@ -148,12 +148,53 @@ func TestUpdatePrivacyHandler(t *testing.T) {
 		OnTenant(mock.DemoTenant).
 		AsUser(mock.JonSnow).
 		ExecutePost(
-			handlers.UpdatePrivacy(),
-			`{ "isPrivate": true }`,
+			handlers.UpdatePrivacySettings(),
+			`{ "isPrivate": true, "isFeedEnabled": false }`,
 		)
 
 	Expect(code).Equals(http.StatusOK)
 	Expect(updateCmd.IsPrivate).IsTrue()
+	Expect(updateCmd.IsFeedEnabled).IsFalse()
+
+	server = mock.NewServer()
+	code, _ = server.
+		OnTenant(mock.DemoTenant).
+		AsUser(mock.JonSnow).
+		ExecutePost(
+			handlers.UpdatePrivacySettings(),
+			`{ "isPrivate": false, "isFeedEnabled": false }`,
+		)
+
+	Expect(code).Equals(http.StatusOK)
+	Expect(updateCmd.IsPrivate).IsFalse()
+	Expect(updateCmd.IsFeedEnabled).IsFalse()
+
+	server = mock.NewServer()
+	code, _ = server.
+		OnTenant(mock.DemoTenant).
+		AsUser(mock.JonSnow).
+		ExecutePost(
+			handlers.UpdatePrivacySettings(),
+			`{ "isPrivate": false, "isFeedEnabled": true }`,
+		)
+
+	Expect(code).Equals(http.StatusOK)
+	Expect(updateCmd.IsPrivate).IsFalse()
+	Expect(updateCmd.IsFeedEnabled).IsTrue()
+
+	server = mock.NewServer()
+	code, _ = server.
+		OnTenant(mock.DemoTenant).
+		AsUser(mock.JonSnow).
+		ExecutePost(
+			handlers.UpdatePrivacySettings(),
+			`{ "isPrivate": true, "isFeedEnabled": true }`,
+		)
+
+	Expect(code).Equals(http.StatusBadRequest)
+	// Should be same as last request
+	Expect(updateCmd.IsPrivate).IsFalse()
+	Expect(updateCmd.IsFeedEnabled).IsTrue()
 }
 
 func TestManageMembersHandler(t *testing.T) {