Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to match both original and compiled path when determining instrumentation eligibility #182

Open
dividedmind opened this issue Jan 27, 2025 · 0 comments

Comments

@dividedmind
Copy link
Collaborator

Currently, in the presence of source maps, only the original source path (with some exceptions) is matched with the package paths configured in appmap.yml.

This can be too restrictive; if trying to trace third-party code, for example, the user usually doesn't care about the original source directory structure but wants to be able to specify the compiled code path in appmap.yml and have it instrumented (even when there is a problem with handling the sourcemap or the map itself, cf. #181).

My intuition is trying to match BOTH the original and transpiled paths and instrumenting if either does match would be more robust and less surprising.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant