You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To change this, supply a space-separated list of globs as the first argument.
I suggest removing "as the first argument". Since the patterns are space-separated, they are interpreted by the shell as multiple arguments. woke parses all arguments, not just the first argument.
This can be something like **/*.go, or a space-separated list of filenames.
It would be worth clarifying the glob expansion is performed by the shell. woke itself is not doing any globbing expansion. In particular, given the ambiguity of the documentation, one might expect the pattern below to be expanded by woke, but it's not.
woke '**/*.go'
This is a bit confusing because different shells have different globbing behaviors. Some shells do not support the double star glob pattern. In bash >= 4, the double star is used as an extended file match globbing operator, meaning it matches filenames and directories recursively. However, the exact behavior depends on the globstar value:
How about adding support for glob expansion in woke? This would provide consistent and deterministic results that do not depend on the shell glob expansion.
Please include the following information:
Version of woke
$ woke --version
# paste output herewoke version 0.18.2
Config file
$ cat .woke.yml
# paste output hereN/A
Go environment
$ go version && go env
# paste output hereN/A
Verbose output of running
$ woke --debug
# paste output hereN/A
The text was updated successfully, but these errors were encountered:
Thank you for creating the issue!
In the documentation at https://github.com/get-woke/woke/blame/main/docs/usage.md#L30-L33:
I suggest removing "as the first argument". Since the patterns are space-separated, they are interpreted by the shell as multiple arguments.
woke
parses all arguments, not just the first argument.It would be worth clarifying the glob expansion is performed by the shell.
woke
itself is not doing any globbing expansion. In particular, given the ambiguity of the documentation, one might expect the pattern below to be expanded bywoke
, but it's not.woke '**/*.go'
This is a bit confusing because different shells have different globbing behaviors. Some shells do not support the double star glob pattern. In bash >= 4, the double star is used as an extended file match globbing operator, meaning it matches filenames and directories recursively. However, the exact behavior depends on the
globstar
value:shopt -s globstar ; woke **/*.go
shopt -u globstar ; woke **/*.go
How about adding support for glob expansion in
woke
? This would provide consistent and deterministic results that do not depend on the shell glob expansion.Please include the following information:
Version of woke
Config file
Go environment
Verbose output of running
The text was updated successfully, but these errors were encountered: