Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve query workload identification #39

Open
ian-whitestone opened this issue Dec 8, 2022 · 0 comments
Open

Improve query workload identification #39

ian-whitestone opened this issue Dec 8, 2022 · 0 comments

Comments

@ian-whitestone
Copy link
Contributor

There's a number of things we could do to improve our workload detection. Right now we just strip out comments and then group by query text, but we can offer other improvements like:

  • Remove database + schema names from all tables in a query (account for users running the same workload on cloned datasets).
  • For CTAS tables, consider only looking at the query text. Looker does stuff like create table database.schema.<looker_unique_identifier>_<table_name> so we don't currently group those together.
  • Strip out literals used in where predicates ( select * from table where user_id = $1). These parameterized queries are common in dashboards and should be grouped together.

As discussed previously with @NiallRees , we want to give users the option to choose between which method they use to group together queries, so these should be kept as separate fields to ensure this flexibility remains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant