Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong check for plugins ZIPs #170

Open
camuffo opened this issue Feb 21, 2025 · 0 comments · May be fixed by #167
Open

Wrong check for plugins ZIPs #170

camuffo opened this issue Feb 21, 2025 · 0 comments · May be fixed by #167
Assignees
Labels

Comments

@camuffo
Copy link
Contributor

camuffo commented Feb 21, 2025

The Dockerfile checks for zip files with [ -f *zip ].
If * is expanded to more that one file, it becomes invalid syntax.


#167 fixes this by using ls.

This screenshots compare contents of two example images.
Both built with two plugins ZIPs in place:

ls resources/geoserver-plugins/
geoserver-2.26.2-mbstyle-plugin.zip  geoserver-2.26-SNAPSHOT-mbtiles-store-plugin.zip

Built with
docker build --build-arg GEOSERVER_WEBAPP_SRC=./geoserver.war --build-arg PLUG_IN_PATHS=./resources/geoserver-plugins --no-cache .

Left: built on branch master / Right: built on branch fix-many-plugins-zips
Image

@camuffo camuffo added the bug label Feb 21, 2025
@camuffo camuffo self-assigned this Feb 21, 2025
@camuffo camuffo linked a pull request Feb 21, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant