Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add source code version information to the docker images #108

Closed
randomorder opened this issue May 3, 2022 · 7 comments
Closed

add source code version information to the docker images #108

randomorder opened this issue May 3, 2022 · 7 comments
Assignees

Comments

@randomorder
Copy link
Member

spawning from #103

would be nice to have a reference to the docker source files version in the final docker image for debugging purposes

@lpasquali
Copy link
Contributor

Hello @zsarkad please read the related issue to understand the context and come back to me

@lpasquali
Copy link
Contributor

lpasquali commented May 26, 2022

Hello @zsarkad

  • Please add an argument to the Dockerfile GIT_HASH
  • Update README if needed with info on the new build arg
  • check custom_build.sh script if is possible to add automatically a variable populated with branch name called DOCKER_REPO_BRANCH
  • Update the builds on docker hub to make use of the build argument

Once changed Dockerfile and custom_build.sh please make a PR against geosolutions-it/docker-geoserver

@zsarkad
Copy link
Contributor

zsarkad commented May 31, 2022

changed Dockerfile, custom_build.sh and README accordingly
made PR request waiting for confirmation from @lpasquali

#109

@zsarkad
Copy link
Contributor

zsarkad commented Jun 13, 2022

uploaded docker image

https://hub.docker.com/r/geosolutionsit/geoserver/tags

@randomorder
Copy link
Member Author

Test latest 2.19 series and 2.20 series as well

@zsarkad
Copy link
Contributor

zsarkad commented Jun 16, 2022

tested 2.19 and 2.20 series , GIT_HASH works well for all images.

As a last step we will be updating builds on the docker hub so asked @lpasquali to help me on this process

@zsarkad
Copy link
Contributor

zsarkad commented Jun 16, 2022

@zsarkad zsarkad closed this as completed Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants