Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Use different strings for 1-month and 1-year full chem benchmark type in run scripts #87

Open
lizziel opened this issue Jun 25, 2020 · 3 comments
Labels
category: Feature Request New feature or request never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output

Comments

@lizziel
Copy link
Contributor

lizziel commented Jun 25, 2020

I noticed our 1-month and 1-year full chem benchmark scripts both have the same benchmark type variable. I think it would be more versatile if we distinguished between the two types.

For example, for budget we pass the benchmark type and it would be useful to determine if it's 1-month or 1-year from that variable in the logic to set units. Right now it checks if the seconds interval is greater than 3e7 to determine if it is 1-year.

Distinguishing between 1-month and 1-year would also enable logic to determine whether to use xarray open_dataset or open_mfdataset which merges multiple files.

@lizziel lizziel added the category: Feature Request New feature or request label Jun 25, 2020
@yantosca yantosca added the never stale Never label this issue as stale label Jan 13, 2021
@msulprizio msulprizio removed the never stale Never label this issue as stale label Mar 3, 2021
@lizziel
Copy link
Contributor Author

lizziel commented Aug 24, 2021

Quick update: I am looking through the latest GCPy and it appears we are still using the same benchmark type string for 1-month and 1-year benchmarks. I will leave this feature request open since distinguishing between 1-month and 1-year will allow greater flexibility.

@yantosca yantosca added the topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output label Aug 30, 2022
@yantosca yantosca reopened this Nov 30, 2023
@yantosca yantosca added never stale Never label this issue as stale and removed no-issue-activity labels Nov 30, 2023
@geoschem geoschem deleted a comment from github-actions bot Feb 22, 2024
@geoschem geoschem deleted a comment from github-actions bot Feb 22, 2024
@yantosca
Copy link
Contributor

We could achieve the same thing by adding a duration flag to the YAML config files. This might be cleaner.

@lizziel
Copy link
Contributor Author

lizziel commented Feb 22, 2024

I agree. If duration is 1-year then it can go into the seasonal plots etc. If 1-month then it will just do a straight comparison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Feature Request New feature or request never stale Never label this issue as stale topic: Benchmark Plots and Tables Issues pertaining to generating plots/tables from benchmark output
Projects
None yet
Development

No branches or pull requests

3 participants