Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percentage of correct segments: Ignore silences between words optionally #13

Open
f90 opened this issue Jul 1, 2019 · 1 comment
Open

Comments

@f90
Copy link
Collaborator

f90 commented Jul 1, 2019

Percentage of correct segments is currently computed by also checking for overlap of predicted and actual silence durations between words. However for Mauch and Jamendo datasets there are no annotated word offsets, so it makes no sense to check for silences in this case.

I had to convert my predictions to have word offset=word onset time of the next word to ensure the metric is correctly calculated in this case, but it feels wrong to have to throw away the models predicted offsets for this.

It would be better to have a flag in the evaluation code that optionally activates/deactivates checking the silence segments so you don't have to change the predictions you feed in.

@georgid
Copy link
Owner

georgid commented Oct 23, 2019

Percentage of correct segments metric by design needs the offset of every word, correct.

A dataset which does not have the word-offset timestamps is practically not suited for this metric. The workaround of adding as offset the next word is feasible, but we have to be careful about the offset of a word, which is the last before a non-vocal segment - e.g. instrumental interlude.

Indeed, currently the evaluation code is doing this workaround itself

This should be changed by either annotating manually the offset of the last word in a seciton or skipping this metric at all.
@f90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants