Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY chart datasets #260

Open
blackst0ne opened this issue Aug 8, 2018 · 0 comments
Open

DRY chart datasets #260

blackst0ne opened this issue Aug 8, 2018 · 0 comments
Labels
charts Analytics charts refactoring Technical debts and code base improvements
Milestone

Comments

@blackst0ne
Copy link
Contributor

blackst0ne commented Aug 8, 2018

#259 brought some duplication to charts' datasets.

That was done to fix weird bugs (see PR and its references).
But the result is not very great because code is duplicated a bit.

All the common data from datasets (excluding data loaded itself) should be extracted to a separate file.
That file should be imported and used in all charts.

@blackst0ne blackst0ne added charts Analytics charts refactoring Technical debts and code base improvements labels Aug 8, 2018
@blackst0ne blackst0ne added this to the Backlog milestone Aug 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
charts Analytics charts refactoring Technical debts and code base improvements
Projects
None yet
Development

No branches or pull requests

1 participant