ENH: optimize export_by_location with e.g. intersects is False #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #606 +/- ##
==========================================
+ Coverage 93.11% 93.74% +0.62%
==========================================
Files 21 21
Lines 4113 4457 +344
==========================================
+ Hits 3830 4178 +348
+ Misses 283 279 -4 ☔ View full report in Codecov by Sentry. |
theroggy
requested changes
Jan 14, 2025
…com/KriWay/geofileops into feature/optimize-export-by-location
theroggy
reviewed
Jan 23, 2025
| "spatial_relations, exp_features", | ||
| [("intersects is True", 1), ("intersects is False", 2)], | ||
| ) | ||
| def test_intersects( |
There was a problem hiding this comment.
Maybe it is clearer to name this module test_export_by_location.py and to put all tests related to export_by_location (also the one(s) now in test_geofileops_twolayers.py) together here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #617
resolves #548