remove getmodbinariesdir & update version

Author: altalk23

CHANGELOG.md

@@ -1,5 +1,9 @@
 # Geode Changelog
 
+## v4.6.2
+ * Fix Windows crashlogs not appearing (02cee65)
+ * Unzip JIT-less iOS binaries separately from the .geode file (85fe11f)
+
 ## v4.6.1
  * Fix several random crashes caused by incorrect relocation code in Tuliphook
  * Make unzip upon download iOS only (0a6d09c)

VERSION

@@ -1 +1 @@
-4.6.1
+4.6.2

loader/include/Geode/loader/Dirs.hpp

@@ -48,8 +48,10 @@ namespace geode::dirs {
      * Directory where mods' unzipped binary files are stored
      * This is used in order to override existing unzip binaries,
      * such as on iOS where signing the binary is required
+     *
+     * TODO: enable on 4.7.0
      */
-    GEODE_DLL std::filesystem::path getModBinariesDir();
+    // GEODE_DLL std::filesystem::path getModBinariesDir();
     /**
      * Directory where mods' config files lie
      */

loader/src/loader/Dirs.cpp

@@ -51,6 +51,6 @@ std::filesystem::path dirs::getModPersistentDir() {
     return dirs::getSaveDir() / "geode-persistent";
 }
 
-std::filesystem::path dirs::getModBinariesDir() {
-    return dirs::getModRuntimeDir() / "binaries";
-}
+// std::filesystem::path dirs::getModBinariesDir() {
+//     return dirs::getModRuntimeDir() / "binaries";
+// }

loader/src/loader/LoaderImpl.cpp

@@ -925,7 +925,9 @@ Result<> Loader::Impl::unzipGeodeFile(ModMetadata metadata) {
 
     // Check if there is a binary that we need to move over from the unzipped binaries dir
     if (this->isPatchless()) {
-        auto src = dirs::getModBinariesDir() / metadata.getBinaryName();
+        // TODO: enable in 4.7.0
+        // auto src = dirs::getModBinariesDir() / metadata.getBinaryName();
+        auto src = dirs::getModRuntimeDir() / "binaries" / metadata.getBinaryName();
         auto dst = tempDir / metadata.getBinaryName();
         if (std::filesystem::exists(src)) {
             std::error_code ec;
@@ -960,7 +962,9 @@ Result<> Loader::Impl::extractBinary(ModMetadata metadata) {
             fmt::format("Unable to find platform binary under the name \"{}\"", metadata.getBinaryName())
         );
     }
-    GEODE_UNWRAP(unzip.extractTo(metadata.getBinaryName(), dirs::getModBinariesDir() / metadata.getBinaryName()));
+    // TODO: enable in 4.7.0
+    // GEODE_UNWRAP(unzip.extractTo(metadata.getBinaryName(), dirs::getModBinariesDir() / metadata.getBinaryName()));
+    GEODE_UNWRAP(unzip.extractTo(metadata.getBinaryName(), dirs::getModRuntimeDir() / "binaries" / metadata.getBinaryName()));
 
     return Ok();
 }