Fix cache dir check to handle boolean true from PHPUnit

AronNovak · AronNovak · commit d7f1d3cbd11a · 2025-10-31T13:32:08.000+01:00
PHPUnit converts XML attribute value='true' to boolean true instead of
string 'true', causing the cache dir check to fail and tests to make
real API calls instead of using cached responses.
diff --git a/src/Provider/Geonames/Tests/GeonamesTest.php b/src/Provider/Geonames/Tests/GeonamesTest.php
@@ -24,7 +24,7 @@ class GeonamesTest extends BaseTestCase
 {
     protected function getCacheDir(): ?string
     {
-        if (isset($_SERVER['USE_CACHED_RESPONSES']) && 'true' === $_SERVER['USE_CACHED_RESPONSES']) {
+        if (isset($_SERVER['USE_CACHED_RESPONSES']) && ($_SERVER['USE_CACHED_RESPONSES'] === true || $_SERVER['USE_CACHED_RESPONSES'] === 'true')) {
             return __DIR__.'/.cached_responses';
         }
 

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ class GeonamesTest extends BaseTestCase`
`24`	`24`	`{`
`25`	`25`	`protected function getCacheDir(): ?string`
`26`	`26`	`{`
`27`		`- if (isset($_SERVER['USE_CACHED_RESPONSES']) && 'true' === $_SERVER['USE_CACHED_RESPONSES']) {`
	`27`	`+ if (isset($_SERVER['USE_CACHED_RESPONSES']) && ($_SERVER['USE_CACHED_RESPONSES'] === true \|\| $_SERVER['USE_CACHED_RESPONSES'] === 'true')) {`
`28`	`28`	`return __DIR__.'/.cached_responses';`
`29`	`29`	`}`
`30`	`30`