Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 64-bit offsets #71

Open
paleolimbot opened this issue Nov 7, 2023 · 0 comments
Open

Add support for 64-bit offsets #71

paleolimbot opened this issue Nov 7, 2023 · 0 comments

Comments

@paleolimbot
Copy link
Contributor

Currently, all offset types are int32_t and iterating over LARGE_WKT and LARGE_WKB is currently not possible. We need to:

  • Ensure that the offsets member of the GeoArrowArrayView can handle int64_t
  • Implement a visitor + writer for LARGE_WKB and LARGE_WKT. There is nothing inherently difficult about this except that doing it in C is hard because there are no templates

While we're changing the GeoArrowArrayView + places that access it, it's worth making a few other changes to ease the cost of updating when adding a few other features:

  • Ensure that serialized types can be represented by a GeoArrowArrayView. Right now there's no place to put the data member and geobuffers() does not work for serialized types
  • Ensure that the coordinate buffer value of double can expand to fit more types, probably by making this type a union. This will ensure that a future version of geoarrow-c that supports float coords won't be source-breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant