Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

text_area: bump RAM quota when the view child requests more RAM #5383

Open
atopia opened this issue Nov 15, 2024 · 0 comments
Open

text_area: bump RAM quota when the view child requests more RAM #5383

atopia opened this issue Nov 15, 2024 · 0 comments

Comments

@atopia
Copy link
Contributor

atopia commented Nov 15, 2024

When the view child requests more RAM, text_area does not try to increase its own RAM quota. The effect is that the editor may fail to render on large screens with Large font sizes (e.g. 4k screen with font size set to Large) unless it is given a high default RAM quota to satisfy the view RAM request.

While a large upfront RAM quota mitigates the problem, the better solution would be for text_area to react to child RAM requests by attempting to raise its own quota if necessary.

atopia added a commit to atopia/genode that referenced this issue Nov 15, 2024
When trying to open a file in the Files view with font size set to
Large on 4k screens, the editor's / `text_area`'s `view` child fails to
bump its RAM quota when the editor's default quota is too small.

To mitigate the issue, bump the editor's default quota to 80MiB.
The long-term fix would be for the editor to request more RAM from the
runtime to satisfy the `view` RAM request.

Issue genodelabs#5356
Issue genodelabs#5383
nfeske pushed a commit that referenced this issue Nov 15, 2024
When trying to open a file in the Files view with font size set to
Large on 4k screens, the editor's / `text_area`'s `view` child fails to
bump its RAM quota when the editor's default quota is too small.

To mitigate the issue, bump the editor's default quota to 80MiB.
The long-term fix would be for the editor to request more RAM from the
runtime to satisfy the `view` RAM request.

Issue #5356
Issue #5383
chelmuth pushed a commit that referenced this issue Nov 20, 2024
When trying to open a file in the Files view with font size set to
Large on 4k screens, the editor's / `text_area`'s `view` child fails to
bump its RAM quota when the editor's default quota is too small.

To mitigate the issue, bump the editor's default quota to 80MiB.
The long-term fix would be for the editor to request more RAM from the
runtime to satisfy the `view` RAM request.

Issue #5356
Issue #5383
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant