From 7673765e517f132b54e366ef3511bc5d3fc48cdb Mon Sep 17 00:00:00 2001 From: Padam Shankhadev Date: Fri, 22 Nov 2024 11:58:39 +0545 Subject: [PATCH 1/3] Support php8.4 --- cli/Valet/PhpFpm.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cli/Valet/PhpFpm.php b/cli/Valet/PhpFpm.php index 6604754..05d260b 100644 --- a/cli/Valet/PhpFpm.php +++ b/cli/Valet/PhpFpm.php @@ -18,7 +18,7 @@ class PhpFpm protected Nginx $nginx; public const SUPPORTED_PHP_VERSIONS = [ - '8.2', '8.3', + '8.2', '8.3', '8.4', ]; public const ISOLATION_SUPPORTED_PHP_VERSIONS = [ From c0880c908bb3530a86d4a3a97aefc1a6bfa0cca4 Mon Sep 17 00:00:00 2001 From: Padam Shankhadev Date: Fri, 22 Nov 2024 12:05:29 +0545 Subject: [PATCH 2/3] Support PHP8.4 --- tests/CliTest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/CliTest.php b/tests/CliTest.php index 8e26127..165e60d 100644 --- a/tests/CliTest.php +++ b/tests/CliTest.php @@ -790,7 +790,7 @@ public function itWillHandleInvalidPhpVersion(): void $this->assertStringContainsString( \sprintf( 'You can still use any version from [%s] list using `valet isolate` command', - '7.0, 7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3' + '7.0, 7.1, 7.2, 7.3, 7.4, 8.0, 8.1, 8.2, 8.3, 8.4', ), $content ); From 64aabed1c6b2aaebd7d4b3e8a8d16b2ac5b5e93a Mon Sep 17 00:00:00 2001 From: Padam Shankhadev Date: Fri, 22 Nov 2024 12:07:06 +0545 Subject: [PATCH 3/3] Support PHP8.4 --- .github/workflows/main.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 6a55133..16132d5 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -11,6 +11,7 @@ jobs: php: - 8.2 - 8.3 + - 8.4 steps: - uses: actions/checkout@v2 - name: Set up PHP @@ -31,6 +32,7 @@ jobs: matrix: php: - 8.3 + - 8.4 steps: - uses: actions/checkout@v2 - name: Set up PHP