-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inferring negative regulation by complex formation (sequestration) #62
Comments
NOT(reaction3... or NOT(reaction2... ? |
Sorry, my parser isn't working properly here. Could you clarify? My intent with the 'NOT' was to say that the complex generated by reaction1 doesn't go off to do something useful to another reaction3. So in the top reaction there, the rule should not activate if the output complex SUMO1:NCOR2 went on to be the input or enabler for another reaction. |
I'm not sure. I think the regulates relationship needs to have a single (regulated) target activity. Can't point to a case immediately, but we certainly have to allow for the possibility that a complex of proteins A and B positively regulates one target activity and negatively regulates a second target activity, and it looks like your logic only allows formation of the A and B complex to have only one kind of regulatory effect. |
The formation of the complex could have other regulatory effects that would be captured by other rules. I see your point though. Why should we stop this rule from activating if the complex has additional functions (as I imagine in reality almost everything probably does)? We should probably get some input from @huaiyumi here as he designed the rule last summer. When it was first implemented, the example we used to test was inferring a negatively_regulates relation from the reaction "The ligand trap binds the ligand BMP2, blocking BMP signalling" to "BMP2 binds to the receptor complex". I see Reactome took out the enabler for BMP2 binds to the receptor complex and added the GO term "sequestering of BMP from receptor via BMP binding" to the ligand trap reaction. As a result the new GO-CAM for that one does not have the causal relationship between the corresponding function nodes. Are you happy with that result ? Are we maybe going too far from Reactome's intent with this inference ? |
Looking at more examples I think this rule definitely needs some reconsideration. e.g. for the pathway 'NTRK2 activates RAC1' it seems to be in conflict with another rule that suggest positive regulation. Just looking at the pathway (and its name) it appears like a positive regulation case, not a negative one. The rule currently activates in 87 pathways: R-HSA-8849474 |
The rule can be improved to avoid cases like the 'NTRK2 activates RAC1' example above by filtering out matches in cases where the target enabler is an active unit of the same complex that is the output of the first reaction. This reduces the 87 pathways to 56 and none of the 56 exhibit the property of having both negative and positive regulation happening between the same 2 reactions. |
There remain many open questions on the 56 pathways that have matches to this rule. Unwinding of DNA is another example where its not clear to me that the rule is identifying regulation. |
Here is an example where it looks like it is working. 'Regulation of TNFR1 signaling' |
@deustp01 my impression here is that this rule may be of use to Reactome curators but is probably not consistently correct enough to be used in the automated conversion. Perhaps we can talk about this one on the call next week. (Unless something else came up in Cambridge that we should discuss.) |
@deustp01 @huaiyumi @ukemi here is a list of the 56 pathways that are impacted by this rule as it stands: You can go direct to the go-cam for each by prepending the identifier with the noctua prefix e.g. http://noctua-dev.berkeleybop.org/editor/graph/gomodel:R-HSA-189451 hsa_id label n_generated_assertions |
Note to check the comment on the asserted relation to ensure you are looking at one generated by this rule and not another regulation rule. The explanation in the comments for this rule will look like this: "The relation 'ALAD condenses 2 dALAs to form PBG' 'directly negatively regulates' 'ALAD binds to Pb2+' was inferred because: 'ALAD binds to Pb2+' has inputs A and B, 'ALAD binds to Pb2+' has output A/B complex, and 'ALAD condenses 2 dALAs to form PBG' is enabled by B. " |
I took a look at the 'NTRK2 activates RAC1' pathway in Reactome. It seems that the resulting complex is an enabler of the subsequent reaction. The issue is the active unit of the subsequent MF is not the entire complex, but a subunit of it. I wonder if that caused the rule to fail. |
Reading through the previous comments, it think you guys already reached the same conclusion. I checked a few pathways in the list. It seems that all of them may due to this problem. |
@deustp01 I checked again and the 2nd list mentioned in the comment above with the 56 pathways is ready for your perusal. (The issue with the active units was indeed already resolved, as you can see in the current noctua-dev model for NTRK2 activates RAC1.) I suspect my next action here should be to take the rule out of the general purpose conversion and thus to close this ticket. We may consider moving this or something like it over into this project: https://github.com/geneontology/pathways2GO/projects/2 - which should get started once we judge the current goal of a general purpose, valid conversion of Reactome into GO-CAMs to be complete. |
Conclusion here is that the rule is often, but not always correct. This provides useful feedback for the Reactome curators, but does not belong in this version of an automated translation. Moving issue to Quality Assurance and Feedback project https://github.com/geneontology/pathways2GO/projects/2 (note also to investigate odd inferences for R-HSA-8866904 ) |
Right now, the rule looks like this:
* If reaction2 is enabled_by entity1
* And reaction1 has entity1 as an input
* And reaction1 has entity2 as an input
* And reaction1 has complex1 containing entity1 and entity2 as output
* And NOT(reaction3 enabled_by | has_input complex1)
* Then infer that reaction1 directly_negatively_regulates reaction2
(by binding up the entity that enables reaction2 to happen).
The rule fires a lot (200+ assertions) for https://reactome.org/PathwayBrowser/#/R-HSA-3899300 . Would like input if this behavior is desirable. Here is an example of what is going on:
The text was updated successfully, but these errors were encountered: