Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Biolink API taxon filtering not behaving as I expected #285

Open
willfitzhugh opened this issue Nov 9, 2020 · 10 comments · Fixed by biolink/ontobio#627
Open

Biolink API taxon filtering not behaving as I expected #285

willfitzhugh opened this issue Nov 9, 2020 · 10 comments · Fixed by biolink/ontobio#627

Comments

@willfitzhugh
Copy link

Hi, I've been using the GO API that is published here - http://api.geneontology.org/api - but am having some basic issues with the results. Not sure if it's an issue with the software or a misunderstanding of how the API is supposed to work.

I am making a call to get the genes associated with a GO term:

http://api.geneontology.org/api/bioentity/function/GO%3A0002544/genes?rows=100&relationship_type=involved_in

This returns genes from all organisms but I am interested in only human genes so then I tried:

http://api.geneontology.org/api/bioentity/function/GO%3A0002544/genes?rows=100&taxon=NCBITaxon%3A9606&relationship_type=involved_in

Which appears to return exactly the same results. I would have thought this would return only human genes. Can you help me with this?

Thanks!

Will

@kltm
Copy link
Member

kltm commented Nov 11, 2020

@willfitzhugh

Unfortunately, you seem to have actually found a bug/oversight in the API. I have opened a ticket and we are tracking it here: monarch-initiative/biolink-api#365 .

@willfitzhugh
Copy link
Author

Thanks for your response and for adding it to the queue to get fixed.

@suzialeksander
Copy link
Collaborator

Note to self: Just checked this search and it appears the fix hasn't come through yet.

@willfitzhugh
Copy link
Author

Hi, just checking, any progress on this?

@suzialeksander
Copy link
Collaborator

@kltm, it looks like the fix is in Ontobio according to monarch-initiative/biolink-api#365 but I'm still seeing this issue. Is there a release or something that needs to update before we see the API working as intended?

@suzialeksander
Copy link
Collaborator

Update, we are still working on this. The issue has been narrowed down to a mismatch of fields between Monarch Solr and GOlr: object_taxon vs taxon. Looks like there's at least one more step needed to fix completely.

@suzialeksander
Copy link
Collaborator

This looks like it's still an active bug, and I have pinged the biolink team again

@rbeagrie
Copy link

I've also just spent an hour trying to work out why taxon filtering wasn't working as expected in the API and just found this bug report. Is there any update on fixing this issue?

@kltm
Copy link
Member

kltm commented May 31, 2022

@rbeagrie My apologies for the slow movement on this. We're currently refactoring the codebase for the API to make fixes easier and this has slowed down some rollout and fixes. I'll check in on the ticket on the biolink tracker (monarch-initiative/biolink-api#365 (comment)).
In the meantime, I might suggest working with the files directly or consider maybe the SPARQL endpoint (if the query is likely to run before it hits the internal timeout).

@sierra-moxon
Copy link
Member

auto-close with my PR, apologies - this should stay open until we deploy the new API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants