Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Language adjustment, especially in German and text size adjustment #31

Open
dodas425 opened this issue Jan 28, 2020 · 21 comments
Open

Language adjustment, especially in German and text size adjustment #31

dodas425 opened this issue Jan 28, 2020 · 21 comments

Comments

@dodas425
Copy link

It would be a nice feature if you could adapt texts in weather.py to German (or other languages). For example date, times of day and days of the week. A simple adjustment of the text size would also be ingenious, so that texts on the info screen and also in the feels like, wind, humidity window could be adjusted accordingly.

@genebean
Copy link
Owner

I will look into the logistics of this but was wondering if you’d be game to help with the actual translations if I provided a list of words / phrases?

@dodas425
Copy link
Author

Naturally! You help me / us so much, then I can help you. What do you need for phrases / words in German?

@dodas425
Copy link
Author

Hello! Do you already have something in the works regarding language integration? I could give you German translations on a timely basis... Greetings Thomas

@dodas425
Copy link
Author

It would also be very nice if you could help me to reduce text size as needed...

@genebean
Copy link
Owner

I have to look at how to do i18n with Python and what it will take to apply that to the code. I may have some time this weekend to poke at it some but am not sure. I greatly appreciate the offer to help translate things though and will take you up on it as soon as I figure the other bits out.

@dodas425
Copy link
Author

Oh, that's very nice! But it doesn't burn... :-)

@genebean
Copy link
Owner

I think this may be easier than I first thought... I will push up a change shortly that adds a new configuration setting so that the results from the Dark Sky api can be in any language they support. For example, here's the daily summary in multiple languages:

  • English: "Possible drizzle in the morning."
  • German: "Nieselregen m\u00f6glich am Vormittag."
  • Czech: "R\u00e1no mo\u017enost mrholen\u00ed."

Note the non-english ones include unicode characters too

@dodas425
Copy link
Author

Further on and on! I'm glad to see you're making progress!

@genebean
Copy link
Owner

Have you tried the setting yet @dodas425 ?

Sent with GitHawk

@dodas425
Copy link
Author

dodas425 commented Mar 2, 2020 via email

@genebean
Copy link
Owner

genebean commented Mar 2, 2020

No problem! The parts that come directly from Dark Sky like the summary are now translated. I just realized that the only documentation of this is in the sample config file though. I’ll get the docs updated and link them here so it’s more clear.

Sent with GitHawk

@dodas425
Copy link
Author

dodas425 commented Mar 7, 2020

IMG_6713
IMG_6712

@dodas425
Copy link
Author

dodas425 commented Mar 7, 2020

Hi there! This is how the 2 views look on my display. Unfortunately, the writing and the texts do not fit on my 320/240 resolution display. Do you already have a solution to my resolution?

@repkadan
Copy link

repkadan commented Mar 7, 2020

@dodas425 Hi look to line 632 in weather.py, you might be a bit further or closer
find this line: time_string = time.strftime("%-d. %b, %-H:%M", time.localtime()) and test this change.

@repkadan
Copy link

repkadan commented Mar 7, 2020

@dodas425 and here is a nice explanation of what each value means. For example, you may have to use only time to fit the text. try it
https://strftime.org/

@repkadan
Copy link

repkadan commented Mar 7, 2020

@dodas425 or there is time and date text size in line 266 self.time_date_text_height = 0.129

In a similar way it will be possible to reduce size other texts

Sorry my English please

@genebean
Copy link
Owner

genebean commented Mar 8, 2020

This coming week I am planning on digging into the issues with the 320 resolution. I had another project with a deadline that has taken my time this week.

Sent with GitHawk

@genebean
Copy link
Owner

https://linkode.org/#RanYQoA2t1cJJVpjFX5PO4 will help with the translation bit

@repkadan
Copy link

repkadan commented May 11, 2020 via email

@genebean
Copy link
Owner

@repkadan sorry, no - the link was because I got @metaMMA to share it with me the other day and I wanted to include it here to keep from losing it. With the move to ClimaCell and the changes I have already merged into the code base its going to be even more important that I deal with all the places that need the language taken into account. Thanks for filling it in too!

@repkadan
Copy link

repkadan commented May 12, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants