Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalize the display of leap years in doy plotting methods #397

Open
12rambau opened this issue Dec 6, 2024 · 0 comments
Open

normalize the display of leap years in doy plotting methods #397

12rambau opened this issue Dec 6, 2024 · 0 comments
Labels
kind: bug Something isn't working kind: enhancement New feature or request

Comments

@12rambau
Copy link
Member

12rambau commented Dec 6, 2024

In the current implementation we simply drop the dayOfYear value which means the days are not corresponding after the first of march when we display leap and non-leap years. This should be normalized during the computation of non-leap year doy.

My main concern is that if we do so, the "earhengine" way of computing date (with doy + year) will be broken. So I think it should only be changed in the plotting methods and kept as it is in the GEE computation. It also need to be explained in the documentation.

@12rambau 12rambau added kind: bug Something isn't working kind: enhancement New feature or request labels Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: bug Something isn't working kind: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant