feat(runtime): Track block gas allowance in builtins #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekovalev
added
A0-pleasereview
ekovalev
force-pushed
the
ek-gas-allowance-in-builtins
branch
from
dd3bbaf
to
0085e4d
Compare
ekovalev
force-pushed
the
ek-gas-allowance-in-builtins
branch
from
0085e4d
to
f1257de
Compare
breathx
requested changes
Nov 26, 2024
| @@ -93,6 +95,9 @@ pub enum BuiltinActorError { | |||
| /// Actor's inner error encoded as a String. | |||
| #[display(fmt = "Builtin execution resulted in error: {_0}")] | |||
| Custom(LimitedStr<'static>), | |||
| /// Occurs if a builtin actor execution does not fit in the current block. | |||
| #[display(fmt = "Block gas allowance exceeded")] | |||
There was a problem hiding this comment.
Im wondering If we could abstract it since it more about how system implemented rather than each particular builtin
| } | ||
|
|
||
| gas_spent += to_spend; | ||
| gas_left -= to_spend; |
There was a problem hiding this comment.
Safe due to a check above - if gas_left is less than to_spend we abort earlier
There was a problem hiding this comment.
But for the sake of universality we can use saturated arithmetics - no problem
| } | ||
|
|
||
| gas_spent += to_spend; | ||
| gas_left -= to_spend; |
breathx
added
A3-gotissues
|
discussed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The initial implementation of builtin actors overlooked the need of keeping track of the block gas allowance. So far only individual message gas limit has been taken in consideration.
Therefore cases of time-consuming computations in builtin actors's
handlemight affect the block time if not checked against available gas allowance.Potential
todo: