Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(idea/voucher-indexer): get program vouchers for spender, is program voucher exists requests #1630

Open
nikitayutanov opened this issue Aug 22, 2024 · 0 comments
Assignees
Labels
C1-feature Feature request D1-idea Gear Idea

Comments

@nikitayutanov
Copy link
Member

nikitayutanov commented Aug 22, 2024

Problem to Solve

Based on #1629.

Send message page, there is program vouchers select for a specific account.
Programs page, there is voucher badge in a program card that demonstrates if program has any active vouchers.

We can use existing /vouchers request to obtain data required for them, however there are few limitations:

  • List in a response is paginated, only first n vouchers will be displayed by default. Since it's a select element, we can't really add pagination there, from a frontend perspective we can only change the design or specify higher limit.
  • Need to send two requests at the same time to display specific program vouchers and vouchers issued for all programs - one with programs: [programId] argument, and another one with programs: [] argument.
  • Not sure about this one, but feels like programs property in a reponse is always empty array, regardless if voucher is for programs and codes or codes only.

Possible Solution

Ideally, we can add two new requests to handle these use cases, or enhance the existing one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C1-feature Feature request D1-idea Gear Idea
Projects
None yet
Development

No branches or pull requests

2 participants