Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Is bower still needed in Polymer Starter Kit 4? #341

Closed
motss opened this issue May 6, 2018 · 6 comments · May be fixed by gcloud-lerralice/tools#68, gcloud-lerralice/tools#69, Exnadella/tools#15 or gcloud-lerralice/tools#86
Closed

Is bower still needed in Polymer Starter Kit 4? #341

motss opened this issue May 6, 2018 · 6 comments · May be fixed by gcloud-lerralice/tools#68, gcloud-lerralice/tools#69, Exnadella/tools#15 or gcloud-lerralice/tools#86
Assignees
@bicknellr
Labels
Package: cli Status: On Hold Type: Bug

Comments

@motss
Copy link

motss commented May 6, 2018 •
edited
Loading

polymer-cli still run bower install in latest Polymer Starter Kit 4.
@rictic
Copy link
Contributor

rictic commented May 9, 2018

polymer install should run npm install if a project has "npm": true in its polymer.json.

What versions of polymer-cli and polymer-starter-kit are you using? Does the polymer.json file have npm: true?

@bicknellr bicknellr reopened this May 9, 2018
@bicknellr
Copy link
Member

Here's where this happens:

tools/packages/cli/src/init/github.ts

Lines 76 to 78 in 8c79b81

install() {
this.installDependencies();
}

Previously it had npm: false, which I removed to make this work with both the old and new PSKs. I was under the impression that Yeoman would install only the ones you used. :/ This could be cleaner if createGithubGenerator accepted the flags for this function as an argument.

@bicknellr bicknellr self-assigned this May 9, 2018
@bicknellr
Copy link
Member

@motss, just to confirm, you're talking about when using polymer init with the polymer-3-starter-kit template, right?

@bicknellr bicknellr mentioned this issue May 10, 2018
Merged
@motss
Copy link
Author

motss commented May 10, 2018

@bicknellr @rictic

Thanks for looking into the issue. Just tested again with the latest Polymer CLI and it still persists.

Polymer CLI version

λ polymer --version
1.7.1

Error message showing bower.

λ polymer init
? Which starter template would you like to use? (Use arrow keys)
> polymer-3-element - A simple Polymer 3.0 element template
? Which starter template would you like to use? polymer-3-starter-kit
info: [init]    Running template polymer-3-starter-kit...
info: [cli.init]    Finding latest ^4.0.0-pre.1 release of Polymer/polymer-starter-kit


I'm all done. Running npm install && bower install for you to install the required dependencies. If this fails, try running the command yourself.



> [email protected] install C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\wd
> node scripts/build-browser-scripts


> [email protected] postinstall C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\spawn-sync
> node postinstall


> [email protected] postinstall C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\sauce-connect-launcher
> node scripts/install.js || nodejs scripts/install.js


> [email protected] postinstall C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\wct-sauce
> node scripts/postinstall.js

Prefetching the Sauce Connect binary.
Missing Sauce Connect local proxy, downloading dependency
This will only happen once.
Downloading 6.48MB
Archive checksum verified.
Unzipping C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\sauce-connect-launcher\sc\sc-4.4.12-win32.zip
Removing C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\sauce-connect-launcher\sc\sc-4.4.12-win32.zip
Sauce Connect downloaded correctly

> [email protected] postinstall C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\wct-local
> node scripts/postinstall.js

----------
selenium-standalone installation starting
----------

---
selenium install:
from: https://selenium-release.storage.googleapis.com/3.8/selenium-server-standalone-3.8.1.jar
to: C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\selenium-standalone\.selenium\selenium-server\3.8.1-server.jar
---
chrome install:
from: https://chromedriver.storage.googleapis.com/2.37/chromedriver_win32.zip
to: C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\selenium-standalone\.selenium\chromedriver\2.37-x64-chromedriver
---
ie install:
from: https://selenium-release.storage.googleapis.com/3.9/IEDriverServer_x64_3.9.0.zip
to: C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\selenium-standalone\.selenium\iedriver\3.9.0-x64-IEDriverServer.exe
---
firefox install:
from: https://github.com/mozilla/geckodriver/releases/download/v0.20.0/geckodriver-v0.20.0-win64.zip
to: C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\selenium-standalone\.selenium\geckodriver\0.20.0-x64-geckodriver
---
edge install:
from: https://download.microsoft.com/download/D/4/1/D417998A-58EE-4EFE-A7CC-39EF9E020768/MicrosoftWebDriver.exe
to: C:\Users\rongsen\Google Drive\motss-windows\test-polymer-3\node_modules\polymer-cli\node_modules\selenium-standalone\.selenium\edgedriver\16299-MicrosoftEdgeDriver.exe


-----
selenium-standalone installation finished
-----
npm WARN optional SKIPPING OPTIONAL DEPENDENCY: [email protected] (node_modules\polymer-cli\node_modules\fsevents):
npm WARN notsup SKIPPING OPTIONAL DEPENDENCY: Unsupported platform for [email protected]: wanted {"os":"darwin","arch":"any"} (current: {"os":"win32","arch":"x64"})

added 1390 packages in 185.526s
bower ENOENT        No bower.json present

@TimvdLippe
Copy link
Contributor

@motss I think #360 should fix this issue. Would you be able to verify so? (Although I think @bicknellr has verified himself it works as intended)

@bicknellr
Copy link
Member

FWIW, the warning at the end (bower ENOENT No bower.json present) shouldn't affect the template initialization.

justinfagnani pushed a commit that referenced this issue Jul 10, 2018
@aomarks
Update test fixtures. (#341)
fc3fe8c 
* Update test fixture sources.
* Delete bower_components from test fixture expected.
* Update test fixture expecteds.
This was referenced Nov 25, 2020
Open
Open
This was referenced Sep 15, 2021
Open
Open
@Exnadella Exnadella mentioned this issue May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bicknellr bicknellr

Labels
Package: cli Status: On Hold Type: Bug
Projects
None yet
Milestone
No milestone
4 participants
@rictic @bicknellr @TimvdLippe @motss