Issue 3371 - Fix passing empty optional stacks to CDK #3372

patchwork01 · 2024-09-27T08:10:04Z

Make sure you have checked all steps below.

My PR addresses the following issues and references them in the PR title. For example, "Issue 1234 - My Sleeper
PR"
- Resolves Can't deploy Sleeper with no optional stacks #3371

My PR adds the following tests OR does not need testing for this extremely good reason:
- Updated SleeperPropertiesTest, OptionalStacksTest

In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
separate issue for that below.
If I have added, removed, or updated any external dependencies used in the project, I have updated the
NOTICES file to reflect this.

patchwork01 force-pushed the 3371-optional-stacks-fix branch from 30deb94 to c433180 Compare September 27, 2024 08:10

patchwork01 changed the base branch from 3368-custom-resource-to-clear-s3-buckets to develop September 27, 2024 08:10

patchwork01 added the one-review-required label Sep 27, 2024

patchwork01 assigned gaffer01 and rtjd6554 Sep 27, 2024

patchwork01 added 2 commits September 27, 2024 08:24

Set optional stacks correctly when passing properties to CDK

0b39cc9

Fix handling unset values

113de67

patchwork01 force-pushed the 3371-optional-stacks-fix branch from 301fb09 to 113de67 Compare September 27, 2024 08:24

patchwork01 changed the base branch from develop to 3373-fix-bulk-import-starter-config-load September 27, 2024 08:24

rtjd6554 approved these changes Sep 27, 2024

View reviewed changes

rtjd6554 assigned patchwork01 and unassigned rtjd6554 Sep 27, 2024

patchwork01 merged commit 4042b56 into 3373-fix-bulk-import-starter-config-load Sep 27, 2024
8 checks passed

patchwork01 deleted the 3371-optional-stacks-fix branch September 27, 2024 08:47

Provide feedback