Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 3368 - Custom resource to clear S3 buckets #3369

Merged
merged 14 commits into from
Sep 30, 2024
Merged

Issue 3368 - Custom resource to clear S3 buckets #3369

merged 14 commits into from
Sep 30, 2024

Conversation

patchwork01
Copy link
Collaborator

@patchwork01 patchwork01 commented Sep 26, 2024 •
edited
Loading

Make sure you have checked all steps below.

Issue

Tests

  • My PR adds the following tests OR does not need testing for this extremely good reason:
    • Tested in AWS

Documentation

  • In case of new functionality, my PR adds documentation that describes how to use it, or I have linked to a
    separate issue for that below.
  • If I have added, removed, or updated any external dependencies used in the project, I have updated the
    NOTICES file to reflect this.

@patchwork01 patchwork01 marked this pull request as ready for review September 26, 2024 15:00
@patchwork01 patchwork01 changed the base branch from develop to 3371-optional-stacks-fix September 27, 2024 08:26
@patchwork01 patchwork01 marked this pull request as draft September 27, 2024 08:44
Base automatically changed from 3371-optional-stacks-fix to 3373-fix-bulk-import-starter-config-load September 27, 2024 08:47
Base automatically changed from 3373-fix-bulk-import-starter-config-load to develop September 27, 2024 08:48
@patchwork01 patchwork01 force-pushed the 3368-custom-resource-to-clear-s3-buckets branch from b701c7d to 20cf2f1 Compare September 27, 2024 09:06
@patchwork01 patchwork01 changed the base branch from develop to 3376-configure-maven-system-tests-from-template September 27, 2024 09:07
@patchwork01 patchwork01 added the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Sep 27, 2024
@patchwork01 patchwork01 marked this pull request as ready for review September 27, 2024 09:17
Base automatically changed from 3376-configure-maven-system-tests-from-template to develop September 30, 2024 12:20
@patchwork01 patchwork01 removed the pr-stacked-top A stacked pull request that we don't want to merge into its target until the target PR is merged label Sep 30, 2024
@gaffer01 gaffer01 removed their assignment Sep 30, 2024
@patchwork01 patchwork01 merged commit 1d471b7 into develop Sep 30, 2024
3 checks passed
@patchwork01 patchwork01 deleted the 3368-custom-resource-to-clear-s3-buckets branch September 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaffer01 gaffer01 gaffer01 approved these changes

Assignees

@rtjd6554 rtjd6554

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom CDK resource to auto-delete S3 objects
3 participants
@patchwork01 @gaffer01 @rtjd6554