Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the auto up versioning in CI #3244

Closed
tb06904 opened this issue Jun 24, 2024 · 0 comments · Fixed by #3245
Closed

Fix the auto up versioning in CI #3244

tb06904 opened this issue Jun 24, 2024 · 0 comments · Fixed by #3245
Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug

Comments

@tb06904
Copy link
Member

tb06904 commented Jun 24, 2024

Describe the bug
If a milestone is open and closed multiple times this will bump the version in the pom it should instead use the version from the milestone every time. We should also be using the CI friendly 'revision' variable for maven to control the top level version.
@tb06904 tb06904 added bug Confirmed or suspected bug automation GitHub Actions, CI/CD labels Jun 24, 2024
@tb06904 tb06904 linked a pull request Jun 24, 2024 that will close this issue
Gh-3244 fix ci versioning #3245
Merged
@github-actions github-actions bot mentioned this issue Jun 24, 2024
Merged
wb36499 pushed a commit that referenced this issue Jul 1, 2024
@tb06904
Gh-3244 fix ci versioning (#3245)
4520b25 
* move to revision property

* update ci

* update ignore
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation GitHub Actions, CI/CD bug Confirmed or suspected bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gh-3244 fix ci versioning gchq/Gaffer
1 participant
@tb06904