Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further differentiation for __DETAILSLOADED__ #523

Open
stefandesu opened this issue Nov 27, 2019 · 0 comments
Open

Further differentiation for __DETAILSLOADED__ #523

stefandesu opened this issue Nov 27, 2019 · 0 comments
Labels
cleanup code cleanup, refactoring, testing... low priority maybe later

Comments

@stefandesu
Copy link
Member

There is a custom property for concepts and schemes called __DETAILSLOADED__ which is only used in Cocoda. It indicates whether details for that particular entity was already loaded from the API. Previously, there were only two states (true or false). For #278, I changed it to use three states: 0 (not loaded), 1 (loaded), -1 (failed to load). Currently the -1 state is indicated by a bolt icon which shows a tooltip that no data is available for said concept.

I think we should also differentiate between "failed to load due to a network error" (which could then be retried at a later point) and "failed to load because of a non-existent URI". I'm not sure if there is currently a way to do this easily because the provider deals with network errors and the loadConcepts method in mixins/objects.js will not be able to catch that error and therefore can't know the difference between the two cases.

It is something to keep in mind for the future, not too relevant at the moment.

@stefandesu stefandesu added the low priority maybe later label Nov 27, 2019
@nichtich nichtich added the cleanup code cleanup, refactoring, testing... label Nov 27, 2019
@stefandesu stefandesu added this to the 1.4.0 milestone Jun 26, 2020
@stefandesu stefandesu modified the milestones: 1.5.0, 1.7.0 Oct 22, 2021
@stefandesu stefandesu removed this from the 1.8.0 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup code cleanup, refactoring, testing... low priority maybe later
Projects
None yet
Development

No branches or pull requests

2 participants