Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup scripts to be more CI and pip friendly #20

Open
gbrammer opened this issue Nov 21, 2022 · 3 comments
Open

Update setup scripts to be more CI and pip friendly #20

gbrammer opened this issue Nov 21, 2022 · 3 comments

Comments

@gbrammer
Copy link
Owner

See the update-setup branch.

TBD:

  • how to include the pieces from the eazy-photoz submodule that are currently symlinked in eazy/data
  • how to include the dependencies of my github clones of the dust_extinction and dust_attenuation packages
@gbrammer
Copy link
Owner Author

@jdavies-st, @ivastar Do you have any suggestions for the items above?

@ivastar
Copy link
Contributor

ivastar commented Nov 21, 2022

@gbrammer which pieces of eazy-photoz do you need for eazy-py? Are you just using the static files (templates, filters, etc.) or do you need for the C modules to be compiled?

@ivastar
Copy link
Contributor

ivastar commented Nov 22, 2022

  • See Download function for templates #21 for a possible alternative to including eazy-photoz as a submodule.
  • Your version of dust_extinction seems to be the same as the original. Can you just include the pip-released version in the setup.cfg file?
  • For dust_attenuation, I'd open a pull request against the repo, seems like most of the changes are big fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants