Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

occurrence dataset page says '0% with coordinates' although all records have coordinates #1953

Open
CecSve opened this issue Aug 5, 2024 · 6 comments

Comments

@CecSve
Copy link

CecSve commented Aug 5, 2024

This dataset has coordinates in the records but the page says 0% with coordinates. I ran the archive through the validator and the only issue I see is that the records are flagged presumed negated latitude longitude. Can you take a look @MortenHofft?

@CecSve CecSve added the bug label Aug 5, 2024
@MattBlissett
Copy link
Member

I think the percentage is for records with coordinates without issues, i.e. these: https://www.gbif.org/occurrence/search?dataset_key=1451240d-1e30-4aa1-a32f-2231aeb39f80&has_coordinate=true&has_geospatial_issue=false

All the records have a negated longitude.

@MortenHofft
Copy link
Member

If you click the file it takes you to the query it performs.
https://www.gbif.org/occurrence/search?dataset_key=1451240d-1e30-4aa1-a32f-2231aeb39f80&has_coordinate=true&has_geospatial_issue=false

So has_geospatial_issue=false
the reason that is the filter is because that is the filter the maps use. That is also the reason the map isn't showing. Because we have a minimum requirement for the coordinates before they show on maps. We could show it as having coordinates, but the map on the dataset page still wouldn't show.
So we do not count what we label as Include records where coordinates are flagged as suspicious

The same goes for years, only if we recognize the year it is counted. For taxa that is more apparent from the text "with match"

@MortenHofft
Copy link
Member

MortenHofft commented Aug 5, 2024

But I can see it is confusing. It would also be odd to show that all records had coordinates and then not show the map though. Perhaps a better text or a [?]-popup would be useful

@MortenHofft MortenHofft removed the bug label Aug 5, 2024
@MortenHofft MortenHofft transferred this issue from gbif/portal-feedback Aug 5, 2024
@CecSve
Copy link
Author

CecSve commented Aug 5, 2024

But I can see it is confusing. It would also be odd to show that all records had coordinates and then not show the map though. Perhaps a better text or a [?]-popup would be useful

Thank you for explaining. I find it a bit odd that the coordinates are showing on the individual occurrence pages (example) and users of the data will also get the records with the interpreted coordinates if they download the dataset archive, but an across-dataset search will exclude the data because they are flagged as suspicious (unless you know how to apply correct filters).

The current way we exclude records with geospatial issues excludes ~4.5 million records for users (and makes sense), but I am not sure the presumed ... flags should be excluded. Perhaps it would make sense to add to the description of the affected fields in the documentation?

@CecSve
Copy link
Author

CecSve commented Aug 5, 2024

@SophiePamerlon would you be able to assist in updating the longitude coordinates if they are wrong?

@SophiePamerlon never mind - the publisher has corrected the issue.

@CecSve
Copy link
Author

CecSve commented Aug 5, 2024

But I can see it is confusing. It would also be odd to show that all records had coordinates and then not show the map though. Perhaps a better text or a [?]-popup would be useful

It would be good if the text said that the records have coordinates when we can interpret the data and flag it. But yes, users would probably benefit from a pop-up and perhaps if it is affected by the flag, then the text could have a different colour to highlight something is off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants