Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors thrown in Occurrence download launcher should result in download being marked as failed #390

Open
djtfmartin opened this issue Feb 25, 2025 · 1 comment
Assignees
Labels

Comments

@djtfmartin
Copy link
Contributor

This was noticed on UAT. An error was thrown:

Caused by: java.lang.RuntimeException: Unknown JSON property 'description'.
        at org.gbif.api.jackson.DownloadRequestSerde.lambda$deserialize$4(DownloadRequestSerde.java:142)
        at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
        at org.gbif.api.jackson.DownloadRequestSerde.deserialize(DownloadRequestSerde.java:142)
        at org.gbif.api.jackson.DownloadRequestSerde.deserialize(DownloadRequestSerde.java:57)
        at com.fasterxml.jackson.databind.deser.SettableBeanProperty.deserialize(SettableBeanProperty.java:545)
        at com.fasterxml.jackson.databind.deser.BeanDeserializer._deserializeWithErrorWrapping(BeanDeserializer.java:570)
        ... 27 common frames omitted

Once this error was thrown, the download was just stuck in a PREPARING state.
The download should perhaps be marked as failed, and then attention can be given to the root cause.

@djtfmartin djtfmartin added the bug label Feb 25, 2025
@MattBlissett
Copy link
Member

In many cases it would be preferable for the launcher to NAK the message, leaving it for later — e.g. if Airflow is temporarily unavailable, it's better than the downloads remain in the queue until it becomes available again.

If the launcher can't handle a download, I think this deserves an email notification, as we have for downloads that fail later in the process.

@marcos-lg marcos-lg self-assigned this Feb 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants