-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FreeBSD: v0.6.0 clang build fails #1091
Comments
I'm not sure, this requires digging in the FreeBSD C library to check why it's not defined. The ...that said, the fact that the error originates from template code in a C++ header hints at a problem entirely contained within the FreeBSD library. You should probably pester them :S Additionally, the compiler differences are likely because the compilers expose different " |
I don't have more skills to inverstigate this but it builds fine with clang 10.0.0 and gcc 11.3.0.
So I will wait for a sameboy new release to see if they found some problems with this version. Thanks |
I can also reproduce that error with my local RGBDS v0.6.0. That's problematic. |
I submitted LIJI32/SameBoy#501 to fix the build error; it boils down to passing |
The API break in rgbgfx is very unfortunate how its impossible to support both older and newer versions of I made a SameBoy issue already. |
API breaks are common in RGBDS; it's still in its 0.x stage after all. |
Strictly speaking, yes; "unfortunately", we also have a fairly large amount of depending projects, so we are somewhere in limbo, and should try to play nice with them. |
This is a fair point, but perhaps a slower transition to the new default would of been better for downstream projects? For example add |
This was the case before the commit you bisected to (d86d24b); external discussion prior to that ruled that the hack was not necessary for downstream projects, i.e. we weren't expecting reliance on colour order as strong as this. |
- Workaround clang build failure on 13.1 and 14 current with USE_GCC gbdev/rgbds#1091 ChangeLog: https://github.com/gbdev/rgbds/releases/tag/v0.6.0
Same problem with 0.6.1: Fails: Rebuilded sameboy and build/test run OK This port uses a configure knob that without it, it fails too on 10.0.1:
Thanks |
Why does it delete the |
Good question! I'm not the creator of this port, I'm a maintainer but I've never had an answer of why this configure tweak is needed. I will test it without OR || part. |
Without |
- yank _POSIX_C_SOURCE because it breaks the build See also: gbdev/rgbds#1091 gbdev/rgbds#1111 Reported by: danfe, gerald
Fixing build on clang >10 removing -D_POSIX_C_SOURCE=200809L https://cgit.freebsd.org/ports/commit/?id=e4d330bbdc82f346bc31f109ebff0d71154362d0 |
I don't think this bug is on our end? At least, I don't think there's anything we can do; therefore, closing this. |
Hello,
v0.6.0 doesn't build with clang 14.0.5 and 13.0.0:
14.0.5 log
13.0.0 log
But it build fine with clang 10.0.1:
log
Any hints?
Thanks
The text was updated successfully, but these errors were encountered: