Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change mypy from release to developement depmendency #25

Closed
josteinl opened this issue Aug 31, 2023 · 1 comment · Fixed by #30
Closed

Change mypy from release to developement depmendency #25

josteinl opened this issue Aug 31, 2023 · 1 comment · Fixed by #30
Assignees
@folt @josteinl
Labels
enhancement New feature or request

Comments

@josteinl
Copy link

I see that mypy is listed as a dependency in the
pyproject.toml

[tool.poetry.dependencies]
mypy = "^1.4.1"  # <-- Suggest moving to dev.dependencies

[tool.poetry.group.dev.dependencies]
mypy = "*"  # <-- Suggest moving mypy here

Also, suggest moving everything from the section [tool.poetry.dev-dependencies] to [tool.poetry.group.dev.dependencies].

If you want a PR, please let me know.

I have not checked if you actually use mypy in your code.
@folt folt self-assigned this Sep 17, 2023
@folt folt added the enhancement New feature or request label Sep 17, 2023
@folt
Copy link
Collaborator

folt commented Sep 17, 2023

Great point, feel free to contribute

@mihail8531 mihail8531 mentioned this issue May 13, 2024
Merged
@folt folt closed this as completed in #30 Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@folt folt

@josteinl josteinl

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add py.typed, move mypy to dev dependencies mihail8531/pydantic-geojson
2 participants
@folt @josteinl