Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

laravel 7 #81

Closed
scwall opened this issue Dec 16, 2020 · 4 comments
Closed

laravel 7 #81

scwall opened this issue Dec 16, 2020 · 4 comments

Comments

@scwall
Copy link

scwall commented Dec 16, 2020

Hello,
I come from python/django and we have the excellent mptt https://github.com/django-mptt/django-mptt for tree management. I'm currently working on a laravel project where I have to integrate the equivalent, I have a lot of data to save on the tree I found the library: https://github.com/lazychaser/laravel-nestedset, but this one is horrible in terms of performance, it's not very user friendly (don't integrate the depth in the database, even after 50 requests ...., especially as it could solve some of the problems). After several researches the Baum library seems to me the closest to what I need in terms of quality and performance. Now I could see that it is not available for laravel 7, will you adapt it for laravel 7 ?
I could see on this post etrepat#332 that @mkwsra has been asking for a traction for a while couldn't there be a work between you ?
Thank you in advance

@poing
Copy link
Collaborator

poing commented Dec 16, 2020

@scwall you'll find that branch 2.0.2 does actually work with Laravel 7. I am using it myself in some projects.

Testbench 5.x tests are run using Laravel 7.

Screen Shot 2020-12-17 at 7 52 33

When I have time, I have been trying to improve test coverage. 2.0.3 is at 80%

Screen Shot 2020-12-17 at 7 50 13

@scwall
Copy link
Author

scwall commented Dec 16, 2020

@poing
Thank you for your answer. I just saw it just now. 😄
I used this to add it to my project, did you proceed the same way or is there another way?

"repositories": [
    {
      "type": "package",
      "package": {
        "name": "baum/v2",
        "version": "2",
        "type": "baum-three",
        "source": {
          "url": "https://github.com/etrepat/baum/",
          "type": "git",
          "reference": "v2"
        }
      }
    }
  ],
  "require": {
    "php": "^7.2.5",
    "baum/v2": "^2", 

Thank you in advance

@poing
Copy link
Collaborator

poing commented Dec 16, 2020

Use: composer require gazsp/baum:2.0.*

etrepat/baum is depreciated and has been forked long ago.

@scwall
Copy link
Author

scwall commented Dec 16, 2020

Perfect 👍 thanks @poing

@poing poing closed this as completed Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants