Skip to content

AddLinkForce alternative #2713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ZenBubble opened this issue Jan 11, 2025 · 9 comments
Open

AddLinkForce alternative #2713

ZenBubble opened this issue Jan 11, 2025 · 9 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We accept pull requests!

Comments

@ZenBubble
Copy link

Desired behavior

In old gazebo, this function was used to apply force relative to a link frame, which made it optimal to use for thrusters for AUVs and any underwater vehicle.

Alternatives considered

Tried using AddWorldForce but the force is applied relative to the world

@ZenBubble ZenBubble added the enhancement New feature or request label Jan 11, 2025
@ZenBubble
Copy link
Author

My current workaround is by taking the world pose of the link and multiplying its quaternion by the desired vector force

@azeey
Copy link
Contributor

azeey commented Jan 13, 2025

Yes, AddWorldForce applies the force at the center of mass of the link, but the force is expressed in world coordinates. An API where the force is expressed in the link frame has not been implemented yet. Would you be interested in contributing a PR?

@azeey azeey added good first issue Good for newcomers help wanted We accept pull requests! labels Jan 13, 2025
@azeey azeey removed this from Core development Jan 13, 2025
@Vedant87
Copy link

Vedant87 commented Mar 7, 2025

Hello, I would like to contribute.

@arjo129
Copy link
Contributor

arjo129 commented Mar 7, 2025

Feel free to open a PR with the new function pointing to main.

@hezek94
Copy link

hezek94 commented Apr 17, 2025

Hi @ZenBubble, I believe this issue is still open, and I’d like to work on it. I will also need some clarification on what exactly is required. Could you please confirm if this PR — [AddLinkForce](https://github.com/gazebosim/gz-sim/pull/2816/files) — is related to this issue?

@Vedant87
Copy link

@ZenBubble I believe this issue is still open, I would like to pick it up and I will be also be needing some up to understand some information about what is needed, I would Like to know if this is link [AddLinkForce] is part of this issue?

The PR introduces an API similar to the one mentioned in the issue, it introduces an API for applying a force expressed in terms of the inertial frame at the inertial or at an offset from the inertial.

@hezek94
Copy link

hezek94 commented Apr 17, 2025

Thanks for this.

@hezek94
Copy link

hezek94 commented Apr 17, 2025

@ZenBubble I believe this issue is still open, I would like to pick it up and I will be also be needing some up to understand some information about what is needed, I would Like to know if this is link [AddLinkForce] is part of this issue?

The PR introduces an API similar to the one mentioned in the issue, it introduces an API for applying a force expressed in terms of the inertial frame at the inertial or at an offset from the inertial.

If I understand correctly, the issue is about implementing a function that makes the applies force at the link’s center of mass and expresses it in the link frame, rather than in the world frame, which has already been implemented?

@hezek94
Copy link

hezek94 commented Apr 17, 2025

I’m not entirely sure of the best approach, but I’ve forked this repository and created a new branch to work from. Should the issue be officially assigned to me, or would it be better if I linked the forked branch here? @Vedant87 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted We accept pull requests!
Projects
None yet
Development

No branches or pull requests

5 participants